Date: Wed, 26 Aug 2020 14:21:24 -0500 From: "Brandon Bergren" <bdragon@FreeBSD.org> To: "Jessica Clarke" <jrtc27@freebsd.org> Cc: "Alan Somers" <asomers@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: =?UTF-8?Q?Re:_svn_commit:_r364799_-_in_head:_share/man/man9_sys/crypto/c?= =?UTF-8?Q?cp_sys/dev/cxgbe/crypto_sys/dev/sec_sys/kern_sys/opencrypto?= Message-ID: <f094f539-f220-42c0-9983-f613aabcbf49@www.fastmail.com> In-Reply-To: <2534D2E5-2974-4067-8B9C-53EE3E8C6A68@freebsd.org> References: <202008260237.07Q2bhwF045988@repo.freebsd.org> <7e0abc1a-a397-46c3-b283-2c1ab21a9c4d@www.fastmail.com> <2534D2E5-2974-4067-8B9C-53EE3E8C6A68@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 26, 2020, at 2:19 PM, Jessica Clarke wrote: > On 26 Aug 2020, at 20:16, Brandon Bergren <bdragon@imap.cc> wrote: > > On Tue, Aug 25, 2020, at 9:37 PM, Alan Somers wrote: > >> Author: asomers > >> Date: Wed Aug 26 02:37:42 2020 > >> New Revision: 364799 > >> URL: https://svnweb.freebsd.org/changeset/base/364799 > >> > >> Modified: head/sys/dev/sec/sec.c > >> ============================================================================== > >> --- head/sys/dev/sec/sec.c Wed Aug 26 02:13:27 2020 (r364798) > >> +++ head/sys/dev/sec/sec.c Wed Aug 26 02:37:42 2020 (r364799) > >> @@ -851,6 +851,9 @@ sec_desc_map_dma(struct sec_softc *sc, struct sec_dma_ > >> case CRYPTO_BUF_MBUF: > >> size = m_length(crp->crp_buf.cb_mbuf, NULL); > >> break; > >> + case CRYPTO_BUF_VMPAGE: > >> + size = PAGE_SIZE - cb->cb_vm_page_offset; > >> + break; > >> default: > >> return (EINVAL); > >> } > > > > Uh, where is cb coming from? Shouldn't this be using crp->crp_buf.cb_vm_page_offset? This is causing a build failure on powerpc and powerpcspe. I don't see why other platforms aren't also erroring out here. > > Because it's PowerPC-specific: > > sys/conf/files.powerpc:dev/sec/sec.c optional sec mpc85xx > > Jess > > No, I mean literally. What scope is cb coming from? It's not a variable that is in scope for that function as far as I can tell. -- Brandon Bergren bdragon@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f094f539-f220-42c0-9983-f613aabcbf49>