Date: Thu, 31 May 2001 22:55:20 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: FUJISHIMA Satsuki <sf@FreeBSD.org> Cc: Warner Losh <imp@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src UPDATING Message-ID: <Pine.BSF.4.21.0105312231160.25702-100000@besplex.bde.org> In-Reply-To: <8666eil46i.wl@cheerful.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 31 May 2001, FUJISHIMA Satsuki wrote:
> I wonder why some Makefile's under src/ use ${INSTALL} -c directly
> rather than ${COPY}. If there isn't a special reason to do so, I would
> like to replace them with ${COPY}.
> ...
> M etc/Makefile
> M etc/isdn/Makefile
> ...
They do this because ${COPY} gives the user's preference for copying
files. Honoring the user's preference for copying in these Makefiles
would have been just a bug in these Makefiles, since the valid preference
of COPY="" would have deleted source files. -c should be used instead
of copy precisely for installing source files.
-c is now the default for install(1), so both -c and ${COPY} have no
effect unless ${COPY} is abused for something other than the user's
preference for copying.
I think the correct fix is to remove all instances of -c and COPY. COPY
is a FreeBSD thing. It was added by rgrimes in FreeBSD-1.x. The .mk
files in 4.4BSD-Lite2 use plain "install" for most generated files, so
the default in 4.4BSD-Lite2 was to remove most generated files after
installing them. I think the default for COPY was always -c in FreeBSD,
and the only reason to have a macro for this was to support bug for bug
compatible behaviour.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0105312231160.25702-100000>