Date: Sun, 27 Jun 2004 01:05:33 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Andrey Chernov <ache@nagual.pp.ru> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern tty.c src/sys/net if_sl.c ppp_tty.c src/sys/netgraph ng_tty.c src/sys/netgraph/bluetooth/drivers/h4 ng_h4.c src/sys/sys linedisc.h tty.h Message-ID: <3322.1088291133@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 26 Jun 2004 17:51:19 %2B0400." <20040626135119.GA29134@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20040626135119.GA29134@nagual.pp.ru>, Andrey Chernov writes: >On Sat, Jun 26, 2004 at 08:44:04AM +0000, Poul-Henning Kamp wrote: >> Fix line discipline switching issues: If opening a new ldisc fails, >> we have to revert to TTYDISC which we know will successfully open >> rather than try the previous ldisc which might also fail to open. > >What about trying to switch to previous ldisc first and, only if it fails, >revert to TTYDISC? Why microptimize something which has always been broken ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3322.1088291133>