Date: Sat, 5 Sep 2020 14:41:28 -0600 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: Kevin Bowling <kevin.bowling@kev009.com>, Mark Linimon <linimon@lonesome.com>, Andrew Gallatin <gallatin@cs.duke.edu>, Alexey Dokuchaev <danfe@freebsd.org>, Michael Tuexen <tuexen@fh-muenster.de>, Pedro Giffuni <pfg@freebsd.org>, Mateusz Guzik <mjg@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph... Message-ID: <CANCZdfprNmczi0mQ7r%2B02inKD4hq9Atn4Zkii9id42iFzxkq-w@mail.gmail.com> In-Reply-To: <CAPyFy2Ce7AJ9y2KCC8=6oWW%2BFhPBV418RjWun1b36HPLuXpnig@mail.gmail.com> References: <202009012119.081LJERb018106@repo.freebsd.org> <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de> <20200902020507.GA38274@FreeBSD.org> <eba32e79-4b90-ecce-7bbb-455f691d4444@FreeBSD.org> <20200902180626.GA88595@FreeBSD.org> <6124a908-25a5-e023-16da-7963ba229b7f@FreeBSD.org> <08636D5E-AA07-4AE7-B5AC-656B08CF564B@fh-muenster.de> <20200903024226.GA54078@FreeBSD.org> <60ea593f-8258-e30d-b897-f162168b44d3@cs.duke.edu> <20200905010510.GA26297@lonesome.com> <CANCZdfo8km1ahTSajJpLhyFyYyQsPr-ZwMWRZx_jmLGdRpc=WA@mail.gmail.com> <CAK7dMtCAktXP4wMDVfC8FeqnEwtMase7kY6Z=-4MazVQQWdXDQ@mail.gmail.com> <CAPyFy2Ce7AJ9y2KCC8=6oWW%2BFhPBV418RjWun1b36HPLuXpnig@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 5, 2020 at 1:42 PM Ed Maste <emaste@freebsd.org> wrote: > On Fri, 4 Sep 2020 at 23:11, Kevin Bowling <kevin.bowling@kev009.com> > wrote: > > > > An arbitrary formater may leave a > > little bit of annoyance to each person's taste, but that is a tiny > > drop in the bucket compared to never having to discuss and especially > > correct (which may /seem/ helpful but is pretty offputting to > > newcomers). > > As an experiment I ran clang-format over an arbitrary file > (vtfontcvt.c) and put the results in > https://reviews.freebsd.org/D26340 > > Relative to the original file there are a few style(9) items that have > been fixed, a few that have been broken, and some that are arguably > worse but really indifferent. > > Fixed: > - *_FOREACH now has a space before (, equivalent to for (;;) > Except pretty much everywhere we don't have a space there... > - header sorting > - space between sizeof and ( removed > - indentation of an if body > - unwrapped function call that fits on one line > > Broken: > - indentation of if / for conditions that span 2 or more lines > broke all alignment of variables and comments that were done. broke all err() calls to wrap too much broke purposely outdented code in statistics function extra headers still included. > > Indifferent: > - lose lined-up struct members or comments > This will cause a huge amount of churn, and is a needless change. It makes things harder to read. Though this alignment style has been slowly waining after being popular early on... The comments moving is a bigger problem for the worse. > - space vs tab after #define > - newlines before quoted function arguments > Also a problem since it introduces more verticality. > - function argument wrapping (see write_glyph_buf) > - leading indentation and args-per-line (print_font_info) > An interesting experiment, but there's far more worse after than before. The rearranging of carefully aligned elements is an especially galling change for some people (myself included). Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfprNmczi0mQ7r%2B02inKD4hq9Atn4Zkii9id42iFzxkq-w>