Date: Wed, 28 Jan 2009 12:26:24 -0800 From: Maksim Yevmenkin <emax@freebsd.org> To: Andrew Thompson <thompsa@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187866 - head/sys/dev/usb2/bluetooth Message-ID: <bb4a86c70901281226l76ae514dr742eae10a75b3f31@mail.gmail.com> In-Reply-To: <20090128201842.GD41780@citylink.fud.org.nz> References: <200901282006.n0SK62pa032130@svn.freebsd.org> <20090128201842.GD41780@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 28, 2009 at 12:18 PM, Andrew Thompson <thompsa@freebsd.org> wrote: > On Wed, Jan 28, 2009 at 08:06:02PM +0000, Maksim Yevmenkin wrote: >> Author: emax >> Date: Wed Jan 28 20:06:02 2009 >> New Revision: 187866 >> URL: http://svn.freebsd.org/changeset/base/187866 >> >> Log: >> Update ubtbcmfw2 (aka usb2_bluetooth_fw) driver >> >> Reviewed by: HPS >> >> enum { >> - UBTBCMFW_BULK_DT_WR, >> - UBTBCMFW_BULK_DT_RD, >> - UBTBCMFW_BULK_CS_WR, >> - UBTBCMFW_BULK_CS_RD, >> - UBTBCMFW_N_TRANSFER = 4, >> + UBTBCMFW_BULK_DT_WR = 0, >> + UBTBCMFW_INTR_DT_RD, >> + UBTBCMFW_N_TRANSFER, >> }; > > I found it more useful the other way around which showed the number of > transfers at a glance of UBTBCMFW_N_TRANSFER. (I realise you removed one) two actually. all transfer stalls are now handled internally (as per HPSs suggestion). in any case, it seemed like a good idea to do it this way because those values used as indexes to an array. just wanted to make sure that all transfers are in their right places :) dont really have a particularly strong opinion on this though :) and its only 2 values we are talking about here :) thanks, max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70901281226l76ae514dr742eae10a75b3f31>