Date: Sun, 09 Aug 2009 12:42:27 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Kevin Oberman <oberman@es.net> Cc: current@freebsd.org, bf@freebsd.org Subject: Re: Unable to build HEAD Message-ID: <4A7F26A3.6000809@FreeBSD.org> In-Reply-To: <20090809014748.284AB1CC31@ptavv.es.net> References: <20090809014748.284AB1CC31@ptavv.es.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I'll let bf take the lead on this one. :) Doug Kevin Oberman wrote: >> Date: Wed, 05 Aug 2009 20:45:11 -0700 >> From: Doug Barton <dougb@FreeBSD.org> >> >> Kevin Oberman wrote: >> >>> OK. I cleaned out /usr/obj and saved /usr/src/sys/i386/conf. >> I'm going to assume that you mean just your conf file there. >> >> >>> While I >>> will have to re-do my kernel config, I prefer to save my old one, >> That's fine, just compare it to GENERIC to make sure that all of your >> entries are valid, and that you're not missing anything important. >> >>> But, as suggested by bf, I think that the WITHOUT_OPENSSH knob is >>> broken which is a problem >> Agreed. If you want to help debug this problem you could try building >> with clean /usr/obj, up to date /usr/src, and ONLY the ssh knob in >> src.conf. Then debug from there. >> >> This (IMWO) is something that should be fixed before release. >> >>> Guess I should have tried V8 a couple of months ago. >> In the immortal words of Jiminy Cricket, let your conscience be your >> guide. :) > > Doug, > > Two patches have been submitted to fix this problem, one by bf > (conf/137483) and one by me (conf/137486). I have confidence that the bf > patch is correct and appropriate and that buildworld is broken with > various src.conf options. I am convinced my patch is correct, > but I suspect that some might argue that it is not appropriate. It > allows pam_ssh to be built even though WITHOUT_OPENSSH is specified. > > I will be happy to defend my patch, if challenged, but the short time > until 8.0 makes it questionable as to whether a consensus can be reached > in time. Whether you like my patch, I'd love to see the patch by bf > (conf/137483) committed before 8.0 and I believe that you agree. If so, > could you request the RE to approve it to be committed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A7F26A3.6000809>