Date: Thu, 05 May 2011 18:02:05 +0400 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221449 - head/sys/geom/journal Message-ID: <4DC2ADDD.6040409@yandex.ru> In-Reply-To: <20110505131242.GC14661@garage.freebsd.pl> References: <201105041806.p44I6edT061463@svn.freebsd.org> <20110505131242.GC14661@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFD4604761B4CDB2D5D3E7B29 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 05.05.2011 17:12, Pawel Jakub Dawidek wrote: >> New Revision: 221449 >> URL: http://svn.freebsd.org/changeset/base/221449 >> >> Log: >> Removed KASSERT, g_new_providerf() can not fail. >=20 > Well, the assertion was there to prepare us for times when > g_new_providerf() will be able to fail. I was suspecting we might want > to make g_new_providerf() to fail when the given name is already in use= =2E I think such change will break all code we have now :) But now when it can not fail, KASSERT could slightly confuse those who read code as example. > In such case we use to create two identical entries in /dev/, not sure > what we do now (panic?). geom_dev prints out an error message. --=20 WBR, Andrey V. Elsukov --------------enigFD4604761B4CDB2D5D3E7B29 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJNwq3dAAoJEAHF6gQQyKF6nF4H/RtUjvQz+7UzpR1s2u+uKq1w D9K/jxbJUY4WWErMPnbVOWH5jp1MsKQcuww1Vjj1SsI8SLQ+3sL7ErBSzvUwcMnq wiJnW3fwKgCokpBNaEmHs4Iu+jo67JS/R3cYwvYsXHG/e9fCSJxZKLh3ENl4peSX taUoxKdGWCjhPAKqabf6oydPWCVUXj39nLNdeleLd44jM5eWpFPhKvRrYWlcJ/7V 5lm2edEppzX5DOL1ZUuBJZVhk9oXcNfqtffwiLu70xMWt2QtNntcoq1kcn41yvNq YJvCrnxYcDv5/yUIXgYyL1t/7ypSY5u2w90E1/L2ZBX6ORLD8RWIIKtXSgkX43Q= =7ydh -----END PGP SIGNATURE----- --------------enigFD4604761B4CDB2D5D3E7B29--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DC2ADDD.6040409>