Date: Wed, 13 Jun 2012 13:13:09 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org Subject: Re: svn commit: r236935 - head/sys/kern Message-ID: <20120613111309.GE1386@garage.freebsd.pl> In-Reply-To: <20120613105344.GB3893@dft-labs.eu> References: <4FD6FD39.5090800@gmail.com> <20120612104749.GB20749@dft-labs.eu> <20120612114335.GA1372@garage.freebsd.pl> <20120612134950.GC20749@dft-labs.eu> <20120612160128.GA1429@garage.freebsd.pl> <20120612191828.GD20749@dft-labs.eu> <20120612214400.GB1429@garage.freebsd.pl> <20120613093807.GA3893@dft-labs.eu> <20120613102900.GD1386@garage.freebsd.pl> <20120613105344.GB3893@dft-labs.eu>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch > > David reported that previous version of the patch fixed panic he was > experiencing, so I consider the patch tested. Looks good, one (hopefully last) minor nit. I'd change this comment: * Search the bitmap for a free descriptor starting at minfd. If none * is found, try to grow the file table. To something like this: * Search the bitmap for a free descriptor starting at minfd. * If none is found, grow the file table. 'try' is a bit misleading for my taste, as it suggest that growing the file table might fail, I think. That's all from me:) -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAk/YdcQACgkQForvXbEpPzRz9ACdGv4lUkw6NG7Ec6wDW9dKdDmZ vGIAoJY1XtySkVRuV5bZCxLwKvd2HZ8m =+RpD -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120613111309.GE1386>