Date: Tue, 19 Nov 2013 23:28:50 +0400 From: Sergey Kandaurov <pluknet@freebsd.org> To: Edward O'Callaghan <eocallaghan@alterapraxis.com> Cc: freebsd-net@FreeBSD.org Subject: Re: [PATCH]: Trivial dmesg formatting. Message-ID: <20131119192850.GA97826@omg> In-Reply-To: <20131120044729.14b495d3.eocallaghan@alterapraxis.com> References: <20131120044729.14b495d3.eocallaghan@alterapraxis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--EeQfGwPcQSOJBaQU
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Nov 20, 2013 at 04:47:29AM +1100, Edward O'Callaghan wrote:
> Index: sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (revision 258349)
> +++ sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c (working copy)
> @@ -182,7 +182,7 @@
> static void
> netvsc_init(void)
> {
> - printf("Netvsc initializing... ");
> + printf("Netvsc initializing... \n");
> =20
> /*
> * XXXKYS: cleanup initialization
Just putting "\n" here is probably not enough to fix formatting. Looking
at the code below I think it was done specially so that the line could be
appended with "Already initialized!", depending on hyperv and boot state.
Personally I'd put the whole thing under bootverbose.
--EeQfGwPcQSOJBaQU
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)
iQEcBAEBAgAGBQJSi7vyAAoJED9Ol7oQYHQZBoMIAK1XK3aiR5/NH/Oa2SEaqOZ1
jD/5o9nTXKGMeX08eymFKM3Hd9C2BUFfhXX+JhC00FCbSBUhhtzmqTWNMUZ1MmpQ
AqKnD0wDVdBJvOjUGbmeOaiIEngbQhHmSRQ75/20HzKrMJqy9H3zR9KXwB8Hbmp4
AyhoHckkbcDHUzr2Y40F1Srx3h91kADqaHDoILSnoDNtw1Ibht/+P+kSPR7RQE+K
9k0LwU/uu8bCv4mjoShfJjV2X5Gh3aXkmb71QL54+SG81aSQiXYj3DW110z++CgJ
LVZf/4UX3JjzX1lQCjuVRq9Ej1RST16kKseWC1QEN8PUyMGXm0Php33q7moZYjU=
=ISQu
-----END PGP SIGNATURE-----
--EeQfGwPcQSOJBaQU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131119192850.GA97826>