Date: Thu, 23 Dec 2010 10:10:16 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216649 - projects/graid/head/sys/geom/raid Message-ID: <20101223090812.GA43446@garage.freebsd.pl> In-Reply-To: <201012220902.oBM92MpZ098772@svn.freebsd.org> References: <201012220902.oBM92MpZ098772@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Dec 22, 2010 at 09:02:22AM +0000, Alexander Motin wrote: > Author: mav > Date: Wed Dec 22 09:02:22 2010 > New Revision: 216649 > URL: http://svn.freebsd.org/changeset/base/216649 > > Log: > Implement basic metadata generation check. To be sure that used metadata is > up to date - delay volumes creation until we have all disks or timeout > expires. This probably obsolete same functionality done at volumes level. [...] > +static struct intel_raid_conf * > +intel_meta_copy(struct intel_raid_conf *meta) > +{ > + struct intel_raid_conf *nmeta; > + > + nmeta = malloc(meta->config_size, M_MD_INTEL, M_WAITOK | M_ZERO); > + memcpy(nmeta, meta, meta->config_size); > + return (nmeta); > +} The M_ZERO flag seems to be redundant, as you fill the entire buffer in the next line. -- Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk0TEfcACgkQForvXbEpPzRvMQCcCCWhgrakk9OEm3cnQjK9wjuT LosAn3/w4KYxA4fMkJdt8weg22aJKvV8 =rbHv -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101223090812.GA43446>