Date: Wed, 17 Jul 2019 09:12:02 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Eygene Ryabinkin <rea@freebsd.org> Cc: freebsd-current@FreeBSD.org Subject: Re: [CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks Message-ID: <20190717071201.beem6et6dybhby7m@ivaldir.net> In-Reply-To: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> References: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Tue, Jul 16, 2019 at 10:31:24PM +0300, Eygene Ryabinkin wrote:
> Good day.
>
> Attached is the patch that makes built-in tbl(1) processor in mandoc
> to avoid dumping core when it renders the table with empty "T{ T}"
> block and horizontally-ruled table.
>
> The simplest way to reproduce the issue is to either
> - run 'man notmuch-config' with mail/notmuch installed;
> - run 'mandoc tests/empty-table-cdata.1' against the attached
> test-only manpage.
>
> With the patch applied, one can utilize 'make check': regression
> test was added. Perhaps an invocation of
> {{{
> mtree -deU -f /usr/src/etc/mtree/BSD.tests.dist -p /usr/tests
> }}}
> will be needed to run 'make check' without remaking/installing
> the world.
>
> The patch is for the fresh -CURRENT. Be interested in any results
> of its application and usage.
>
> Thanks!
>
> P.S.: please, CC me: I am not subscribed to the list.
> --
> Eygene Ryabinkin ,,,^..^,,,
> [ Life's unfair - but root password helps! | codelabs.ru ]
> [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
Hello,
Thank you for the patch! Have it been discussed with upstream? I kind of remind
something like this being reported to upstream, but I haven't checked the
status.
Best regards,
Bapt
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0uykEACgkQY4mL3PG3
PlplQQ/9HfYngYZrPKLVUczfqzkOfZHp/lm0N9QfvGgnuGePAMpiruLyvAF4Iaom
g1mKM9FVmga40ccbg+GGeqrdPzqJBExrdgykfaiOYPzadJuuvGKMZTJXcpMUXhOP
hasyw+uf8dY+PuA09uvRPhsaqTrHMf+qyKNIj2r+/+MOUV2bk1pRHQVXB7WxcYRm
u0/oeW7Kkjm8LyMPR/2MNF4bhx5v4vupZfgXF99v4s3KV6L01BP6+sXNyhg+Pk0O
FN+Uwzqq5FTcPFu4I+so8zU7ManuX0NHOGHK9eEIEP65wIh65BTGP2qexWtOsuyv
VlOqn/Q4+ZjIACtZPhZx0rjPUOGG8SaqCJc3CS/HTKn4tWOAoPbHOvZT1XFlzmn6
+8kGLqZ9khIEiYfSmDDQxiZV4S1bNoNBDd/16CTFWUfUThJaJUocJ3dnAR4kv6Xq
TGLoWtJ7lSqTrcWZMj3ulBv6xqrtsdU63MfFjnYIj2fXWD/cI1X79uMPD0omvQ/9
gtsOKgq8QEipvg2fewg2mdd8bFPNNq8vUZcBZ1sqBJVj8RJMmXJpIfexaWNNXI7a
nQtbmal1eLOMvTrZh/W3NRUBKXArF6fTCVJHb5vUfzB6bdIiTR/V90rJVTnJ3afb
bTcTENutdicIQlZvHhf761dkgguo9MCs9kK0ahyepLS/9AdBclw=
=7Yds
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190717071201.beem6et6dybhby7m>