Date: Thu, 8 May 2014 09:43:15 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> Cc: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: Centrino Wireless-N 1000 support is also broken (Re: iwn(4) in -HEAD supporting Centrino Wireless-N 135) Message-ID: <CAJ-VmoktP6GnMY4YYx=x3DmSrSK7tUGmy%2Bd=VObRCdFAHxFmTw@mail.gmail.com> In-Reply-To: <14909.1399545008@elam.kais.kyoto-u.ac.jp> References: <CAJ-Vmo=y77Eh9CCevN4cAWn23SZ1cG=gCq9YMPeJ4xeP6j77Gw@mail.gmail.com> <20140226123709.GA31099@syn.pertho.net> <CAJ-Vmom=b5tPTh1qWNG=zV5qM=Wzf1BRe5%2B2-ndrR648NSFmkw@mail.gmail.com> <530EE7F4.3080903@shurik.kiev.ua> <CAJ-VmomsEdS5nm8rX6245rAEhVxWeOc4aO9AYrmEBHuUKHG=Tw@mail.gmail.com> <24791.1393550277@elam.kais.kyoto-u.ac.jp> <CAJ-Vmo=wZyMM1uWTyFV=Yb3vd=EmfiW_NY5Vp1c-JmV5hF2ENA@mail.gmail.com> <75498.1398751548@elam.kais.kyoto-u.ac.jp> <CAJ-VmokVPA0rQSwins3NuppV%2B2ypYLCTF0nFGeU828GLpPp2KQ@mail.gmail.com> <84650.1398819225@elam.kais.kyoto-u.ac.jp> <CAJ-Vmo=0t%2BzoJ0HwArHkQnpBbHas5WiKj%2Be9y_T3SFsFsuiewA@mail.gmail.com> <CAJ-VmomHvEqJQ-2C9hr4TRD%2BG-a-LgYSG2Z_ESDM-_ndRE4LFA@mail.gmail.com> <CAJ-Vmo=tv3-LkU5WJENFedK5EqtRDxUsbQAK=rin_zDZiOZfSQ@mail.gmail.com> <14909.1399545008@elam.kais.kyoto-u.ac.jp>
index | next in thread | previous in thread | raw e-mail
Hi!
Cool!
So what's the value of txchainmask and rxchainmask from the EEPROM?
before things get overridden?
I'd like to figure out what that changed.
Thanks!
-a
On 8 May 2014 03:30, Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> wrote:
> Hello adrian,
>
> Thank you for a patch, and I'm sorry for late reply.
> Your patch fixes the problem. ".calib_need" flag's change helps.
> Other changes doesn't need to fix, but they doesn't
> seem to make any problem.
>
> The minimum necessary change is below.
> if_iwn.c : no change
> if_iwn_chip_cfg.h: remove IWN_FLG_NEED_PHY_CALIB_DC,
> add IWN_FLG_NEED_PHY_CALIB_TX_IQ_PERIODIC
>
>
> Index: if_iwn_chip_cfg.h
> ===================================================================
> --- if_iwn_chip_cfg.h (revision 265665)
> +++ if_iwn_chip_cfg.h (working copy)
> @@ -219,8 +219,9 @@
> .regulatory_bands = iwn5000_regulatory_bands,
> .enhanced_TX_power = false,
> .calib_need =
> - ( IWN_FLG_NEED_PHY_CALIB_DC
> - | IWN_FLG_NEED_PHY_CALIB_LO
> + (
> + IWN_FLG_NEED_PHY_CALIB_LO
> + | IWN_FLG_NEED_PHY_CALIB_TX_IQ_PERIODIC
> | IWN_FLG_NEED_PHY_CALIB_TX_IQ
> | IWN_FLG_NEED_PHY_CALIB_BASE_BAND ),
> .support_hostap = false,
>
> --
> Kaho Toshikazu
>
>
> Adrian Chadd <adrian@freebsd.org> wrote:
>
>> Hi!
>>
>> Would you mind trying this?
>>
>> What values do you have for sc_txchainmask and sc_rxchainmask? Before
>> they're over-ridden?
>>
>> Thanks!
>>
>>
>> -a
>>
>> adrian@sabrina:~/work/freebsd/head/src/sys/dev/iwn % svn diff .
>> Index: if_iwn.c
>> ===================================================================
>> --- if_iwn.c (revision 265478)
>> +++ if_iwn.c (working copy)
>> @@ -744,6 +744,8 @@
>> sc->limits = &iwn1000_sensitivity_limits;
>> sc->base_params = &iwn1000_base_params;
>> sc->fwname = "iwn1000fw";
>> + /* XXX override chainmasks? */
>> + sc->txchainmask = IWN_ANT_AB;
>> break;
>> default:
>> device_printf(sc->sc_dev, "adapter type id : 0x%04x sub id :"
>> Index: if_iwn_chip_cfg.h
>> ===================================================================
>> --- if_iwn_chip_cfg.h (revision 265478)
>> +++ if_iwn_chip_cfg.h (working copy)
>> @@ -219,14 +219,18 @@
>> .regulatory_bands = iwn5000_regulatory_bands,
>> .enhanced_TX_power = false,
>> .calib_need =
>> - ( IWN_FLG_NEED_PHY_CALIB_DC
>> + (
>> +// IWN_FLG_NEED_PHY_CALIB_DC
>> | IWN_FLG_NEED_PHY_CALIB_LO
>> + | IWN_FLG_NEED_PHY_CALIB_TX_IQ_PERIODIC
>> | IWN_FLG_NEED_PHY_CALIB_TX_IQ
>> - | IWN_FLG_NEED_PHY_CALIB_BASE_BAND ),
>> + | IWN_FLG_NEED_PHY_CALIB_BASE_BAND
>> + ),
>> .support_hostap = false,
>> .no_multi_vaps = true,
>> .additional_gp_drv_bit = IWN_GP_DRIVER_NONE,
>> - .bt_mode = IWN_BT_NONE,
>> +// .bt_mode = IWN_BT_NONE,
>> + .bt_mode = IWN_BT_SIMPLE,
>> .plcp_err_threshold = IWN_PLCP_ERR_EXT_LONG_THRESHOLD,
>> };
>> static const struct iwn_base_params iwn_6000_base_params = {
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmoktP6GnMY4YYx=x3DmSrSK7tUGmy%2Bd=VObRCdFAHxFmTw>