Date: Fri, 17 Nov 2017 21:30:12 +0100 From: Oliver Pinter <oliver.pinter@hardenedbsd.org> To: Conrad Meyer <cem@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325957 - in head: sys/kern tests/sys/vfs Message-ID: <CAPQ4ffuwEgyvxxXdt0dfMpnwi1a7JqysyuEHRbf4N4%2BUMvqqvg@mail.gmail.com> In-Reply-To: <201711171925.vAHJPeuN074946@repo.freebsd.org> References: <201711171925.vAHJPeuN074946@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, November 17, 2017, Conrad Meyer <cem@freebsd.org> wrote: > Author: cem > Date: Fri Nov 17 19:25:39 2017 > New Revision: 325957 > URL: https://svnweb.freebsd.org/changeset/base/325957 > > Log: > vfs_lookup: Allow PATH_MAX-1 symlinks > > Previously, symlinks in FreeBSD were artificially limited to PATH_MAX-2. > > Add a short test case to verify the change. > > Submitted by: Gaurav Gangalwar <ggangalwar AT isilon.com> > Reviewed by: kib > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D12589 > > Added: > head/tests/sys/vfs/lookup_test.sh (contents, props changed) > Modified: > head/sys/kern/vfs_lookup.c > head/tests/sys/vfs/Makefile > > Modified: head/sys/kern/vfs_lookup.c > ============================================================ > ================== > --- head/sys/kern/vfs_lookup.c Fri Nov 17 19:10:10 2017 (r325956) > +++ head/sys/kern/vfs_lookup.c Fri Nov 17 19:25:39 2017 (r325957) > @@ -499,7 +499,7 @@ namei(struct nameidata *ndp) > error = ENOENT; > break; > } > - if (linklen + ndp->ni_pathlen >= MAXPATHLEN) { > + if (linklen + ndp->ni_pathlen > MAXPATHLEN) { > if (ndp->ni_pathlen > 1) > uma_zfree(namei_zone, cp); > error = ENAMETOOLONG; > > Modified: head/tests/sys/vfs/Makefile > ============================================================ > ================== > --- head/tests/sys/vfs/Makefile Fri Nov 17 19:10:10 2017 (r325956) > +++ head/tests/sys/vfs/Makefile Fri Nov 17 19:25:39 2017 (r325957) > @@ -7,6 +7,8 @@ TESTSDIR= ${TESTSBASE}/sys/vfs > ATF_TESTS_C+= lookup_cap_dotdot > CFLAGS.lookup_cap_dotdot.c+= -I${SRCTOP}/tests > > +#ATF_TESTS_SH+= lookup_test This commented out line is intended? > + > TAP_TESTS_SH+= trailing_slash > > .include <bsd.test.mk> > > Added: head/tests/sys/vfs/lookup_test.sh > ============================================================ > ================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/tests/sys/vfs/lookup_test.sh Fri Nov 17 19:25:39 2017 > (r325957) > @@ -0,0 +1,17 @@ > +# $FreeBSD$ > + > +long_symlink_head() > +{ > + atf_set "descr" "Test for 1023 (PATH_MAX-1) symlink support" > +} > +long_symlink_body() > +{ > + atf_check -s exit:0 ln -s aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/ > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/ > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaa > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa sym_long > + # was: "stat: sym_long: stat: File name too long"; exit 1 > + atf_check -s exit:0 -o ignore stat -L sym_long > +} > + > +atf_init_test_cases() > +{ > + atf_add_test_case long_symlink > +} > _______________________________________________ > svn-src-head@freebsd.org <javascript:;> mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org > <javascript:;>" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffuwEgyvxxXdt0dfMpnwi1a7JqysyuEHRbf4N4%2BUMvqqvg>