Date: Thu, 13 Dec 2001 15:42:50 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Sheldon Hearn <sheldonh@starjuice.net> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/smbfs smbfs_vfsops.c Message-ID: <20011213154249.C19995@sunbay.com> In-Reply-To: <603.1008249558@axl.seasidesoftware.co.za> References: <200112131308.fBDD8Zm59173@freefall.freebsd.org> <603.1008249558@axl.seasidesoftware.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 13, 2001 at 03:19:18PM +0200, Sheldon Hearn wrote: > > > On Thu, 13 Dec 2001 05:08:35 PST, Sheldon Hearn wrote: > > > Modified files: > > sys/fs/smbfs smbfs_vfsops.c > > Log: > > Add module dependency on libmchain. > > > > With this change, mounting an smb share (using mount_smb, which is not > > yet included in the tree) without any of smbfs, libiconv or libmchain > > compiled into the kernel or loaded works. > > I included <sys/module.h>, which is already included by <sys/kernel.h>. > > I did this because I'm guessing it's _not_ okay to assume that > <sys/kernel.h> will include <sys/module.h>. > > Am I right, or should I remove the explicit inclusion of <sys/module.h>? > Look at the line preceding the inclusion of <sys/module.h> in <sys/kernel.h>. :-) Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011213154249.C19995>