Date: Fri, 17 Feb 2017 10:51:40 -0600 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313821 - in head/sys: dev/cxgb/ulp/iw_cxgb fs/nfsserver kern netinet netinet/libalias netpfil/ipfw Message-ID: <c8e82548-f8ae-23c0-4bbf-1ac2f2ebb5bb@FreeBSD.org> In-Reply-To: <20170217041748.GI58829@FreeBSD.org> References: <201702162047.v1GKlf9j014479@repo.freebsd.org> <20170217041748.GI58829@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/16/2017 22:17, Gleb Smirnoff wrote: > Eric, > > heh, things are worse. Multiple places you changes are CTR() > macros. Neither inet_ntoa() nor inet_ntoa_r() will work with > them. :( > > Basicly non-constant strings can not be logged with KTR. All > the lines you touched should log actual binary value of the > IPv4 address. *facepalm* It's even worse, because I /knew/ about this, but I failed to think of it while making this change. Oh well. > I am not asking you to do this work! :) But I couldn't leave > that without a comment. :) Thanks for mentioning it. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c8e82548-f8ae-23c0-4bbf-1ac2f2ebb5bb>