Date: Thu, 11 Mar 2010 10:46:25 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: Marius Strobl <marius@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r204974 - head/lib/libc/sparc64/fpu Message-ID: <20100310234625.GA69658@server.vk2pj.dyndns.org> In-Reply-To: <201003101955.o2AJtmrP046136@svn.freebsd.org> References: <201003101955.o2AJtmrP046136@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
One bug that crept in somewhere:
On 2010-Mar-10 19:55:48 +0000, Marius Strobl <marius@FreeBSD.org> wrote:
>Modified: head/lib/libc/sparc64/fpu/fpu.c
>@@ -181,15 +182,11 @@ __fpu_dumpfpn(struct fpn *fp)
> }
> #endif
>
>-static int opmask[] = {0, 0, 1, 3};
>+static const int opmask[] = {0, 0, 1, 3, 1};
>
...
>Modified: head/lib/libc/sparc64/fpu/fpu_emu.h
>==============================================================================
>--- head/lib/libc/sparc64/fpu/fpu_emu.h Wed Mar 10 19:55:27 2010 (r204973)
>+++ head/lib/libc/sparc64/fpu/fpu_emu.h Wed Mar 10 19:55:48 2010 (r204974)
>@@ -140,7 +140,7 @@ struct fpn {
> #define FTYPE_SNG INSFP_s
> #define FTYPE_DBL INSFP_d
> #define FTYPE_EXT INSFP_q
>-#define FTYPE_LNG -1
>+#define FTYPE_LNG 5
FTYPE_* are used as indexes into opmask[]. Somewhere along the line,
FTYPE_LNG has changed from 4 to 5 but the opmask[] initialisers still
assume 4. (It might be worth adding a comment into opmask[] so this
relationship is noted in future).
--
Peter Jeremy
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAkuYL1EACgkQ/opHv/APuIcZygCdFUUbJsCEYa+hxoib53TcKu0x
bCIAnj0t8dJ8nZb6TLkyqLzjsBZw4+hH
=PZ6y
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100310234625.GA69658>