Date: Fri, 17 Jan 2020 20:46:42 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Dimitry Andric <dim@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r356832 - head/lib/libc/gen Message-ID: <CAGudoHGHLLZQUX1Ts65pxUcke=8hx3i2o0K%2B5073Qz6Zg0P4sg@mail.gmail.com> In-Reply-To: <75C1E5B4-41B3-4C97-9794-1D684884A0E5@FreeBSD.org> References: <202001171545.00HFjdMw003501@repo.freebsd.org> <75C1E5B4-41B3-4C97-9794-1D684884A0E5@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/17/20, Dimitry Andric <dim@freebsd.org> wrote: > On 17 Jan 2020, at 16:45, Mateusz Guzik <mjg@freebsd.org> wrote: >> >> Author: mjg >> Date: Fri Jan 17 15:45:39 2020 >> New Revision: 356832 >> URL: https://svnweb.freebsd.org/changeset/base/356832 >> >> Log: >> libc: fix build after r356830 >> >> Apparently building with 'cd lib/libc; make all install' is not the same >> as buildworld. > > Definitely not, indeed. Such a plain make will use your system's > headers for inclusion, not those in /usr/src. Only use this when you > are certain those headers are up-to-date (or up-to-date enough ;). > That's not the difference I meant. Building like above works fine with: unionstack = _fcntl(fd, F_ISUNIONSTACK); It's only buildworld during which this fails with: /usr/src/lib/libc/gen/opendir.c:282:40: error: too few arguments provided to function-like macro invocation unionstack = _fcntl(fd, F_ISUNIONSTACK); hence the patch. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHGHLLZQUX1Ts65pxUcke=8hx3i2o0K%2B5073Qz6Zg0P4sg>