Date: Fri, 01 Nov 2024 22:16:19 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Colin Percival <cperciva@freebsd.org>, <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org> Subject: Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs Message-ID: <0FC811CD-24E2-48E0-8F06-C75CFEB3FBBE@panasas.com> In-Reply-To: <a698a48d-7ec9-4fce-a98d-f9955c5ed37e@freebsd.org> References: <202410312247.49VMl6TW031342@gitrepo.freebsd.org> <6E1A6F2E-C236-4A23-BFD2-8D917A02D5C2@panasas.com> <a698a48d-7ec9-4fce-a98d-f9955c5ed37e@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yes, it was the previous change, not this one. And yes, simply adding 'acpi= _if.h' to the Makefile did the trick. I went ahead and committed it: 9709bda= 03cd0 Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: <owner-src-committers@freebsd.org <mailto:owner-src-committers@freebs= d.org>> on behalf of Colin Percival <cperciva@freebsd.org <mailto:cperciva@f= reebsd.org>> Date: Friday, November 1, 2024 at 19:13 To: Ravi Pokala <rpokala@freebsd.org <mailto:rpokala@freebsd.org>>, <src-co= mmitters@FreeBSD.org <mailto:src-committers@FreeBSD.org>>, <dev-commits-src-= all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-commits-src-= main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD.org>> Subject: Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting= archs On 11/1/24 18:34, Ravi Pokala wrote: > This seems to have broken arm64.LINT-FDT: >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > % less _.arm64.LINT-FDT > ... > -------------------------------------------------------------- >>>> stage 3.1: building everything > -------------------------------------------------------------- > In file included from /usr/home/rpokala/freebsd/src/clean-main/sys/dev/gp= io//gpioaei.c:37: > /usr/home/rpokala/freebsd/src/clean-main/sys/dev/acpica/acpivar.h:34:10: = fatal error: 'acpi_if.h' file not found > 34 | #include "acpi_if.h" > | ^~~~~~~~~~~ > 1 error generated. > *** [gpioaei.o] Error code 1 >=20 > make[8]: stopped making "all" in /usr/home/rpokala/freebsd/src/clean-main= /sys/modules/gpio/gpioaei Oops. It was probably the earlier commit which broke it, but I'm clearly not good at kernel modules. Can you check if adding "acpi_if.h" to SRCS in src/sys/modules/gpio/gpioaei/Makefile fixes the problem? --=20 Colin Percival FreeBSD Release Engineering Lead & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0FC811CD-24E2-48E0-8F06-C75CFEB3FBBE>