Date: Thu, 05 Dec 2019 11:15:58 -0700 From: Ian Lepore <ian@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com>, Konstantin Belousov <kostikbel@gmail.com> Cc: Kubilay Kocak <koobs@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355407 - head/sys/fs/tmpfs Message-ID: <2db52a541d0a48ec0e706de2fb4605749f9c4fa4.camel@freebsd.org> In-Reply-To: <80859C2E-1973-4E89-BAD2-5586CC683504@gmail.com> References: <20191205133544.GE2744@kib.kiev.ua> <80859C2E-1973-4E89-BAD2-5586CC683504@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2019-12-05 at 10:05 -0800, Enji Cooper wrote: > > On Dec 5, 2019, at 05:36, Konstantin Belousov <kostikbel@gmail.com> > > wrote: > > ... > > > > Could you elaborate on the why/rationale? > > > > > > Is there memory wastage/duplication, bug(s), performance or > > > development/maintenance benefit? > > > > Each mount/unmount of tmpfs created and destroyed two zones, as it > > is > > easy to see from the patch. > > Commit messages should provide helpful summaries of changes. Having > to look at and understand the patch requires domain knowledge which > the reader may or may not have. Kubilay’s request seems valid to me. > > -Enji I agree. You read the diff to see the details of what changed. You read the commit message to see why. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2db52a541d0a48ec0e706de2fb4605749f9c4fa4.camel>