Date: Sun, 17 Nov 2002 10:17:25 -0800 From: "Sam Leffler" <sam@errno.com> To: "Luigi Rizzo" <luigi@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/netinet ip_output.c ip_var.h Message-ID: <081a01c28e65$9528df00$52557f42@errno.com> References: <200211171630.gAHGUjtH096646@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I really dislike the ip_fragment api. In particular you're passing m as
call-by-reference and returning multiple values to communicate multiple
different possible returns. This a programming practice I dislike greatly.
Please work with me to eliminate this. I'm also not happy with your
commiting functional changes (e.g. ip_fragment) and style changes together.
Sam
----- Original Message -----
From: "Luigi Rizzo" <luigi@FreeBSD.org>
To: <cvs-committers@FreeBSD.org>; <cvs-all@FreeBSD.org>
Sent: Sunday, November 17, 2002 8:30 AM
Subject: cvs commit: src/sys/netinet ip_output.c ip_var.h
> luigi 2002/11/17 08:30:44 PST
>
> Modified files:
> sys/netinet ip_output.c ip_var.h
> Log:
> Move the ip_fragment code from ip_output() to a separate function,
> so that it can be reused elsewhere (there is a number of places
> where it can be useful). This also trims some 200 lines from
> the body of ip_output(), which helps readability a bit.
>
> (This change was discussed a few weeks ago on the mailing lists,
> Julian agreed, silence from others. It is not a functional change,
> so i expect it to be ok to commit it now but i am happy to back it
> out if there are objections).
>
> While at it, fix some function headers and replace m_copy() with
> m_copypacket() where applicable.
>
> MFC after: 1 week
>
> Revision Changes Path
> 1.171 +168 -143 src/sys/netinet/ip_output.c
>
http://cvsweb.FreeBSD.org/src/sys/netinet/ip_output.c.diff?r1=1.170&r2=1.171
> 1.69 +2 -0 src/sys/netinet/ip_var.h
> http://cvsweb.FreeBSD.org/src/sys/netinet/ip_var.h.diff?r1=1.68&r2=1.69
>
>
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?081a01c28e65$9528df00$52557f42>