Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Jul 2013 01:01:27 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 231392 for review
Message-ID:  <201307240101.r6O11RFm033087@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@231392?ac=10

Change 231392 by rwatson@rwatson_cinnamon on 2013/07/24 01:01:23

	Add two missing previously() quantifiers that lead to surprising
	behaviour.

Affected files ...

.. //depot/projects/ctsrd/tesla/src/sys/ufs/ffs/ffs_vnops.c#15 edit
.. //depot/projects/ctsrd/tesla/src/sys/ufs/ufs/ufs_vnops.c#5 edit

Differences ...

==== //depot/projects/ctsrd/tesla/src/sys/ufs/ffs/ffs_vnops.c#15 (text+ko) ====

@@ -1720,8 +1720,8 @@
 #ifdef MAC
 #ifdef TESLA_MAC
 	TESLA_SYSCALL(incallstack(ufs_setacl) ||
-	    mac_vnode_check_setextattr(ANY(ptr), ap->a_vp,
-	    ap->a_attrnamespace, ap->a_name) == 0);
+	    previously(mac_vnode_check_setextattr(ANY(ptr), ap->a_vp,
+	    ap->a_attrnamespace, ap->a_name) == 0));
 #endif
 #endif
 

==== //depot/projects/ctsrd/tesla/src/sys/ufs/ufs/ufs_vnops.c#5 (text+ko) ====

@@ -276,7 +276,7 @@
 #ifdef MAC
 #ifdef TESLA_MAC
 	TESLA_SYSCALL(incallstack(kern_execve) ||
-	    mac_vnode_check_open(ANY(ptr), vp, ANY(int)) == 0);
+	    previously(mac_vnode_check_open(ANY(ptr), vp, ANY(int)) == 0));
 #endif
 #endif
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307240101.r6O11RFm033087>