Date: Tue, 12 Apr 2005 08:17:57 +0200 From: Michael Nottebrock <michaelnottebrock@gmx.net> To: obrien@FreeBSD.org Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/archivers/gzip Makefile ports/archivers/ucl Makefile ports/archivers/lzop Makefile ports/archivers/cabextract Makefile ports/archivers/dact Makefile ports/archivers/star Makefile ports/archivers/arj Makefile ports/archivers/tardy ... Message-ID: <200504120818.02749.michaelnottebrock@gmx.net> In-Reply-To: <20050412055628.GA6385@dragon.NUXI.org> References: <200504110804.j3B84fNs060515@repoman.freebsd.org> <200504120603.10518.michaelnottebrock@gmx.net> <20050412055628.GA6385@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2708905.TgPHC5M6cU Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday, 12. April 2005 07:56, David O'Brien wrote: > > The porter's handbook, section 5.11 has an example that uses > > MACHINE_ARCH, which is the template for a lot of MACHINE_ARCH usage in > > ports, > > I wondered how this got copied around so many times. > > > including a few places your commit missed, like bsd.gnome.mk, > > bsd.kde.mk, bsd.gnustep.mk and, most importantly, bsd.port.subdir.mk > > and bsd.port.mk itself (for setting CONFIGURE_TARGET(!)). > > I purposefully didn't touch Mk/*.mk. I have to assume the authors of > them got it right. :-) Well, you did however change ports that do nothing but mimic what bsd.ports= =2Emk=20 does (like audio/arts and x11/kdelibs3, which is why I noticed at all)...=20 Anyway: If the usage of MACHINE_ARCH for setting the build-target of=20 autoconf-generated configure scripts is indeed wrong and possibly harmful,= =20 this would affect a *very* large number of ports and your big commit would= =20 have fixed only a comparatively small number. =2D-=20 ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org --nextPart2708905.TgPHC5M6cU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQBCW2gaXhc68WspdLARAs5JAJ4ppX0/OtyOAHoj6ZqNfilJMMC5hwCeK83K sSd8ktCRRP03BRlLq2ONdpw= =8AyF -----END PGP SIGNATURE----- --nextPart2708905.TgPHC5M6cU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504120818.02749.michaelnottebrock>