Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Feb 2015 22:56:48 +0100
From:      Michael Gmelin <grembo@freebsd.org>
To:        Marcel Moolenaar <marcel@xcllnt.net>
Cc:        freebsd-current Current <freebsd-current@freebsd.org>, Peter Wemm <peter@wemm.org>
Subject:   Re: nagios vs w/uptime
Message-ID:  <20150210225648.10cda499@bsd64.grem.de>
In-Reply-To: <E36EA56E-3B9E-4C40-B984-E7BE97F0175E@freebsd.org>
References:  <54DA617A.4090309@wemm.org> <A3904FE0-2D03-4290-B29E-395E8C6F6F96@xcllnt.net> <4A76A371-B573-4E62-BE78-94944963FFD0@freebsd.org> <E36EA56E-3B9E-4C40-B984-E7BE97F0175E@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


On Tue, 10 Feb 2015 22:24:59 +0100
Michael Gmelin <grembo@freebsd.org> wrote:

>=20
>=20
>=20
> > On 10 Feb 2015, at 22:17, Michael Gmelin <grembo@freebsd.org> wrote:
> >=20
> >=20
> >=20
> >=20
> >> On 10 Feb 2015, at 21:13, Marcel Moolenaar <marcel@xcllnt.net>
> >> wrote:
> >>=20
> >> [Moving to current@]
> >>=20
> >>> On Feb 10, 2015, at 11:52 AM, Peter Wemm <peter@wemm.org> wrote:
> >>>=20
> >>> Surprises:
> >>> * nagios doesn't like w / uptime anymore. libxo perhaps?
> >>=20
> >> Seems most likely, although I haven=E2=80=99t seen any differences in
> >> output in my (admittedly limited) testing.
> >>=20
> >> In what way does Nagios not like w/uptime?
> >> Any concrete errors, output or misbehavior?
> >> Ideally: can you reproduce the problem?
> >=20
> >=20
> > Just compared 10.1 to current, unmodified output looks the same,
> > but pipelines don't work properly:
> >=20
> > 10.1:
> > # uptime | wc
> > 1 12 68
> >=20
> > Current:
> > # uptime | wc
> > 0 0 0
> >=20
> > # uptime | cat
> > # uptime
> > 10:16PM  up 9 mins...
> >=20
>=20
> Adding xo_finish() to w.c line 268 just right before exit(0); fixes
> that issue (I don't know libxo well enough to say if this is the
> proper fix or just a workaround, but it seems logical to me).
>=20

I opened a code review request:
https://reviews.freebsd.org/D1821

--=20
Michael Gmelin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150210225648.10cda499>