Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Jul 2013 13:47:01 +0400
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Adrian Chadd <adrian@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r253314 - head/sys/net
Message-ID:  <20130715094701.GO8839@FreeBSD.org>
In-Reply-To: <201307130425.r6D4P31J078644@svn.freebsd.org>
References:  <201307130425.r6D4P31J078644@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 13, 2013 at 04:25:03AM +0000, Adrian Chadd wrote:
A> Author: adrian
A> Date: Sat Jul 13 04:25:03 2013
A> New Revision: 253314
A> URL: http://svnweb.freebsd.org/changeset/base/253314
A> 
A> Log:
A>   Bring over some link aggregation / LACP protocol improvements and debugging
A>   additions.
A>   
A>   * Add some new tracing events to aid in debugging.
A>   * Add in a debugging mode to drop transmit and received frames, specifically
A>     to test whether seeing or hearing heartbeats correctly cause LACP to
A>     drop the port.
A>   * Add in (and make default) a strict LACP mode, which requires the
A>     heartbeat on a port to be heard before it's used.  Sometimes vendor ports
A>     will hang but the link layer stays up, resulting in hung traffic.
A>   * Add logging the number of link status flaps, again to aid in debugging
A>     badly behaving switch ports.
A>   * Calculate the lagg interface port speed as the multiple of the
A>     configured ports, rather than the largest.

Having the txtest, rxtest and lacp_strict a global sysctls makes them
useless on a box that has more than one aggregate interface. Turning
test on will down all laggs on a box.

IMO, these should be ioctls that can be configured per-interface via
ifconfig, and in perfect case documented in ifconfig.8.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130715094701.GO8839>