Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Aug 2014 11:46:00 -0400
From:      Adam McDougall <mcdouga9@egr.msu.edu>
To:        svn-src-all@freebsd.org
Subject:   Re: svn commit: r269975 - in stable/10: . sys/dev/ixgbe
Message-ID:  <53ECD9B8.7000502@egr.msu.edu>
In-Reply-To: <201408141407.s7EE75lC013864@svn.freebsd.org>
References:  <201408141407.s7EE75lC013864@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 08/14/2014 10:07, Steven Hartland wrote:
> Author: smh
> Date: Thu Aug 14 14:07:05 2014
> New Revision: 269975
> URL: http://svnweb.freebsd.org/changeset/base/269975
> 
> Log:
>   Make the ixgbe tunables now match their sysctl counterparts.
>   
>   Previously the tunables and sysctls had different names for example:
>   hw.ixgbe.enable_aim => hw.ix.enable_aim
>   
>   Anyone using ixgbe tunables should ensure they update /boot/loader.conf.
>   
>   This is a direct commit to stable as the changes to sysctls in head
>   already fix this issue in a different way.
>   
>   Sponsored by:	Multiplay
> Modified: stable/10/sys/dev/ixgbe/ixgbe.c
> ==============================================================================
> --- stable/10/sys/dev/ixgbe/ixgbe.c	Thu Aug 14 13:57:17 2014	(r269974)
> +++ stable/10/sys/dev/ixgbe/ixgbe.c	Thu Aug 14 14:07:05 2014	(r269975)
> @@ -244,18 +244,18 @@ static SYSCTL_NODE(_hw, OID_AUTO, ix, CT
>  ** traffic for that interrupt vector
>  */
>  static int ixgbe_enable_aim = TRUE;
> -TUNABLE_INT("hw.ixgbe.enable_aim", &ixgbe_enable_aim);
> +TUNABLE_INT("hw.ix.enable_aim", &ixgbe_enable_aim);
>  SYSCTL_INT(_hw_ix, OID_AUTO, enable_aim, CTLFLAG_RW, &ixgbe_enable_aim, 0,
>      "Enable adaptive interrupt moderation");

I'm not using ix yet, but could you retain the old tunables in 10 as
hidden ones so configurations do not break?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53ECD9B8.7000502>