Date: Sun, 30 Dec 2001 02:56:52 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: David Malone <dwmalone@maths.tcd.ie> Cc: "David E. O'Brien" <obrien@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/share/mk bsd.sys.mk Message-ID: <20011230025454.U405-100000@gamplex.bde.org> In-Reply-To: <200112291435.aa83853@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 29 Dec 2001, David Malone wrote: > > > WARNS=4 doesn't seem to be the same as WARNS=2 used to be, because > > > -Wno-uninitialized isn't getting added at the end of the warnings > > > flags and so -Wuninitialized is still producing false positives. > > > Could someone review the patch below? > > > Doesn't it work where it already is, since it is to cancel the > > -Wuninitialized provied by -Wall? > > It doesn't seem to work - try setting WARNS=4 and then compiling > usr.bin/getcat. I've just checked and it seems that -W also sets > -Wuninitialised: I suspected that, but checked the man page and it didn't mention it. The code is clearer :-). > Did the patch look OK, or is there some other way I should be doing > this? It's OK. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011230025454.U405-100000>