Date: Thu, 24 Nov 2016 15:21:08 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kubilay Kocak <koobs@FreeBSD.org> Cc: Dag-Erling Sm??rgrav <des@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309109 - head/lib/libutil Message-ID: <20161124152108.GA20603@FreeBSD.org> In-Reply-To: <c120ab6b-99b6-c139-f691-4d01c034d427@FreeBSD.org> References: <201611241450.uAOEoLA5079215@repo.freebsd.org> <c120ab6b-99b6-c139-f691-4d01c034d427@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 25, 2016 at 01:56:36AM +1100, Kubilay Kocak wrote: > On 25/11/2016 1:50 AM, Dag-Erling Sm??rgrav wrote: > > +/* + * Reliably open and lock a file. + * + * DO NOT, UNDER PAIN OF > > DEATH, modify this code without first reading the + * revision > > history and discussing your changes with <des@freebsd.org>. + * Don't > > be fooled by the code's apparent simplicity; there would be no + * > > need for this function if it was as easy to get right as you think. + > > */ (Garbled quoting; please fix you MUA.) > This comes as close to obvious territoriality in FreeBSD as I've seen to > date and it's especially disappointing to see coming from someone many > look up to and consider a senior project developer. Apparently des@ was/is unhappy about unthought changes made to this code; what exactly makes his wish territorialiting and disappointing? > While we all may understand the frustration associated with people > changing code they don't understand, I believe we need less fear > associated with contributing to FreeBSD and that this is a big step in > the wrong direction. Dag-Erling's comment is perfectly fine; loud and clear. Those who want to contribute should read the prior history and ping des@; I don't see anything wrong with this (and given how reluctantly people are eager to do "svn blame" these days, I don't think this is uncalled). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161124152108.GA20603>