Date: Thu, 28 Jun 2018 01:05:41 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335733 - in head: bin/csh gnu/usr.bin/cc/cc1 gnu/usr.bin/cc/cc1plus gnu/usr.bin/cc/cc_tools lib/libmagic lib/libpam/static_libpam lib/ncurses/ncurses share/syscons/scrnmaps stand/mips/... Message-ID: <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> In-Reply-To: <edf27226-3540-8843-1a98-5b611590a69c@FreeBSD.org> References: <201806271929.w5RJTGwa049250@repo.freebsd.org> <1903115A-F018-4075-961A-65689595FBEE@FreeBSD.org> <0d1b366a-59ab-65e9-58a6-5474f538cad2@FreeBSD.org> <edf27226-3540-8843-1a98-5b611590a69c@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 27 Jun 2018, at 22:53, John Baldwin <jhb@freebsd.org> wrote: > > On 6/27/18 12:45 PM, Bryan Drewery wrote: >> On 6/27/2018 12:35 PM, Dimitry Andric wrote: >>> On 27 Jun 2018, at 21:29, Bryan Drewery <bdrewery@FreeBSD.org> wrote: >>>> >>>> Author: bdrewery >>>> Date: Wed Jun 27 19:29:15 2018 >>>> New Revision: 335733 >>>> URL: https://svnweb.freebsd.org/changeset/base/335733 >>>> >>>> Log: >>>> Don't use CCACHE for linking. >>>> >>>> MFC after: 2 weeks >>>> Sponsored by: Dell EMC >>>> >>>> Modified: >>>> head/bin/csh/Makefile >>>> head/gnu/usr.bin/cc/cc1/Makefile >>>> head/gnu/usr.bin/cc/cc1plus/Makefile >>>> head/gnu/usr.bin/cc/cc_tools/Makefile >>>> head/lib/libmagic/Makefile >>>> head/lib/libpam/static_libpam/Makefile >>>> head/lib/ncurses/ncurses/Makefile >>>> head/share/syscons/scrnmaps/Makefile >>>> head/stand/mips/beri/boot2/Makefile >>>> head/usr.bin/vi/catalog/Makefile >>>> >>>> Modified: head/bin/csh/Makefile >>>> ============================================================================== >>>> --- head/bin/csh/Makefile Wed Jun 27 19:28:37 2018 (r335732) >>>> +++ head/bin/csh/Makefile Wed Jun 27 19:29:15 2018 (r335733) >>>> @@ -113,7 +113,7 @@ build-tools: gethost >>>> >>>> gethost: gethost.c sh.err.h tc.const.h sh.h ${BUILD_TOOLS_META} >>>> @rm -f ${.TARGET} >>>> - ${CC} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICONV//} \ >>>> + ${CC:N${CCACHE_BIN}} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICONV//} \ >>>> ${TCSHDIR}/gethost.c >>> >>> Looks like a good candidate for a common macro, say CC_NOCACHE, CC_REAL >>> or something like that? :) >> >> Yeah probably. I'd paint it CC_LINK. > > CCLD was my initial thought *duck* Actually, that is not bad, and something I have seem more often. In the sense that ${LD} would be e.g. /usr/bin/ld or at least, a "low level" linker, while ${CCLD} would be the compiler driver doing the work. Maybe it is specifically for these cases, that you don't directly use ${CC}, but ${CCLD}... -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWzQYRQAKCRCwXqMKLiCW o1W7AKD1Ca+ZFklz2ZjeRcF/mZddy6cQ/QCeLSq+JuNmemQx3IFByIgdcp3Fumg= =QkHv -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5223ED3B-6286-4A1B-8DB7-86BF11417F96>