Date: Sat, 23 Jan 1999 19:42:38 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: David Greenman <dg@root.com> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c Message-ID: <199901240342.TAA57652@apollo.backplane.com> References: <199901240328.TAA13629@implode.root.com>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:>dillon 1999/01/23 17:15:58 PST
:>
:> Modified files:
:> sys/kern uipc_syscalls.c
:> Log:
:> There was a situation where sendfile() might attempt to initiate I/O
:> on a PG_BUSY page, due to a bug in its sequencing of a conditional.
:
: Huh? Would you please explain this further?
The original conditional was:
if (pg == NULL || (!(pg->flags & PG_BUSY) && !pg->busy &&
!vm_page_is_valid(pg, pgoff, xfsize))) {
...
... wire page and start I/O ...
} else {
... wait for page ...
}
Hmmm. lemme read this again. Oops, I think you are
right, that wasn't a bug. Well, consider keeping the new
code anyway, it's more readable then the old code.
-Matt
:-DG
:
:David Greenman
:Co-founder/Principal Architect, The FreeBSD Project
:
:
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901240342.TAA57652>