Date: Sun, 20 Nov 2005 23:13:58 +0530 From: Joseph Koshy <joseph.koshy@gmail.com> To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Specifying alternative file for devd(8) Message-ID: <84dead720511200943ua2cf8b8y49bff0dcf3e2fa63@mail.gmail.com> In-Reply-To: <20051120172755.GA85641@freebsd.czest.pl> References: <20051120172755.GA85641@freebsd.czest.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
wk> http://freebsd.czest.pl/dunstan/FreeBSD/diff.0.devd wk> Comments are welcome! Manual page comments: -->><<-- +.It Fl f Ar file +Use file as configuration file instead of /etc/devd.conf (default). "Use configuration file .Ar file instead of the default .Pa /etc/devd.conf ." -->><<-- +(or alternative file specified with +.Fl f +flag) and uses that file to drive the rest of the process. While the +format of this file is described in ".Fl f option" is clearer. Flags usually are booleans. Sentences start on a new line. -->><<-- diff -upr /usr/src/sbin/devd/devd.cc src/sbin/devd/devd.cc --- /usr/src/sbin/devd/devd.cc=09Mon Nov 14 03:01:10 2005 +++ src/sbin/devd/devd.cc=09Sun Nov 20 18:07:08 2005 You should probably also mention in the manual page that only one (the last) '-f' option has an effect. The manual page also needs a .Sh FILES section that lists /etc/devd.conf. Otherwise the patch looks fine. -- FreeBSD Volunteer, http://people.freebsd.org/~jkoshy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?84dead720511200943ua2cf8b8y49bff0dcf3e2fa63>