Date: Thu, 07 Feb 2002 15:38:55 -0800 From: Peter Wemm <peter@wemm.org> To: Julian Elischer <julian@elischer.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha db_trace.c locore.s machdep.c pmap.c prom.c sys_machdep.c vm_machdep.c src/sys/alpha/linux linux_machdep.c linux_sysvec.c src/sys/alpha/osf1 imgact_osf1.c src/sys/compat/pecoff imgact_pecoff.c src/sys/ddb db_ps.c ... Message-ID: <20020207233855.C793239F1@overcee.wemm.org> In-Reply-To: <Pine.BSF.4.21.0202071518190.91961-100000@InterJet.elischer.org>
index | next in thread | previous in thread | raw e-mail
Julian Elischer wrote:
>
>
> On Thu, 7 Feb 2002, Andrew Gallatin wrote:
>
> >
> >
> > Peter Wemm [peter@wemm.org] wrote:
> > > Julian Elischer wrote:
> > > > julian 2002/02/07 12:58:48 PST
> > >
> > > > Reviewed by: peter@freebsd.org, gallatin@cs.duke.edu, benno rice,
> > >
> > > NO! This was *NOT* reviewed by me. I haven't even *seen* it!
>
> Ummm we spent two hours together on the phone going through these
> changes...
No, that was the kse diff, on sunday.. You had not even started this diff
then. I said on many occasions during that readthrough that there were
problems that should be fixed before committing, and that both you and I
would read through the diff before it was committed, since it is blatently
obvious where the mistakes are.
This kind of thing stands out like a sore thumb:
@@ -2331,15 +2332,18 @@
ttyprintf(tp, "empty foreground process group\n");
else {
mtx_lock_spin(&sched_lock);
+
/* Pick interesting process. */
for (pick = NULL; p != 0; p = LIST_NEXT(p, p_pglist))
if (proc_compare(pick, p))
pick = p;
Maybe I overreacted. Dealing with pacbell is not a good way to calm the
nerves. But I also don't appreciate being listed as a reviewer when I
haven't even seen the actual change, and when I explicitly said "let me
read it first".
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020207233855.C793239F1>