Date: Wed, 27 Jun 2018 16:08:54 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org>, John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335733 - in head: bin/csh gnu/usr.bin/cc/cc1 gnu/usr.bin/cc/cc1plus gnu/usr.bin/cc/cc_tools lib/libmagic lib/libpam/static_libpam lib/ncurses/ncurses share/syscons/scrnmaps stand/mips/... Message-ID: <64cf10b3-d10b-77d1-f11f-b2a7c5542213@FreeBSD.org> In-Reply-To: <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> References: <201806271929.w5RJTGwa049250@repo.freebsd.org> <1903115A-F018-4075-961A-65689595FBEE@FreeBSD.org> <0d1b366a-59ab-65e9-58a6-5474f538cad2@FreeBSD.org> <edf27226-3540-8843-1a98-5b611590a69c@FreeBSD.org> <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WEeo83sTe4aDfZ7do2k183HpjXSuvX1bC Content-Type: multipart/mixed; boundary="TcXLP9xI3d83lYBqekeDi8NQ0tflClLoe"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org>, John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <64cf10b3-d10b-77d1-f11f-b2a7c5542213@FreeBSD.org> Subject: Re: svn commit: r335733 - in head: bin/csh gnu/usr.bin/cc/cc1 gnu/usr.bin/cc/cc1plus gnu/usr.bin/cc/cc_tools lib/libmagic lib/libpam/static_libpam lib/ncurses/ncurses share/syscons/scrnmaps stand/mips/... References: <201806271929.w5RJTGwa049250@repo.freebsd.org> <1903115A-F018-4075-961A-65689595FBEE@FreeBSD.org> <0d1b366a-59ab-65e9-58a6-5474f538cad2@FreeBSD.org> <edf27226-3540-8843-1a98-5b611590a69c@FreeBSD.org> <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> In-Reply-To: <5223ED3B-6286-4A1B-8DB7-86BF11417F96@FreeBSD.org> --TcXLP9xI3d83lYBqekeDi8NQ0tflClLoe Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/27/2018 4:05 PM, Dimitry Andric wrote: > On 27 Jun 2018, at 22:53, John Baldwin <jhb@freebsd.org> wrote: >> >> On 6/27/18 12:45 PM, Bryan Drewery wrote: >>> On 6/27/2018 12:35 PM, Dimitry Andric wrote: >>>> On 27 Jun 2018, at 21:29, Bryan Drewery <bdrewery@FreeBSD.org> wrote= : >>>>> >>>>> Author: bdrewery >>>>> Date: Wed Jun 27 19:29:15 2018 >>>>> New Revision: 335733 >>>>> URL: https://svnweb.freebsd.org/changeset/base/335733 >>>>> >>>>> Log: >>>>> Don't use CCACHE for linking. >>>>> >>>>> MFC after: 2 weeks >>>>> Sponsored by: Dell EMC >>>>> >>>>> Modified: >>>>> head/bin/csh/Makefile >>>>> head/gnu/usr.bin/cc/cc1/Makefile >>>>> head/gnu/usr.bin/cc/cc1plus/Makefile >>>>> head/gnu/usr.bin/cc/cc_tools/Makefile >>>>> head/lib/libmagic/Makefile >>>>> head/lib/libpam/static_libpam/Makefile >>>>> head/lib/ncurses/ncurses/Makefile >>>>> head/share/syscons/scrnmaps/Makefile >>>>> head/stand/mips/beri/boot2/Makefile >>>>> head/usr.bin/vi/catalog/Makefile >>>>> >>>>> Modified: head/bin/csh/Makefile >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>>> --- head/bin/csh/Makefile Wed Jun 27 19:28:37 2018 (r335732) >>>>> +++ head/bin/csh/Makefile Wed Jun 27 19:29:15 2018 (r335733) >>>>> @@ -113,7 +113,7 @@ build-tools: gethost >>>>> >>>>> gethost: gethost.c sh.err.h tc.const.h sh.h ${BUILD_TOOLS_META} >>>>> @rm -f ${.TARGET} >>>>> - ${CC} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICONV//} \ >>>>> + ${CC:N${CCACHE_BIN}} -o gethost ${LDFLAGS} ${CFLAGS:C/-DHAVE_ICON= V//} \ >>>>> ${TCSHDIR}/gethost.c >>>> >>>> Looks like a good candidate for a common macro, say CC_NOCACHE, CC_R= EAL >>>> or something like that? :) >>> >>> Yeah probably. I'd paint it CC_LINK. >> >> CCLD was my initial thought *duck* >=20 > Actually, that is not bad, and something I have seem more often. In th= e > sense that ${LD} would be e.g. /usr/bin/ld or at least, a "low level" > linker, while ${CCLD} would be the compiler driver doing the work. > Maybe it is specifically for these cases, that you don't directly use > ${CC}, but ${CCLD}... >=20 +1 --=20 Regards, Bryan Drewery --TcXLP9xI3d83lYBqekeDi8NQ0tflClLoe-- --WEeo83sTe4aDfZ7do2k183HpjXSuvX1bC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbNBkHAAoJEDXXcbtuRpfPnuQH/jLqf/yAi1FES5Zpqq2k4tnb DxPx4h7FGXXJgWRZMiNxy+fdBMlVMTi+QWZj8IMykPKLVlXPiBwaQcxmm4HItvYR PPml72RC9thPllYZyybUvs+2yzUcUT/AbITUHQcnqwtnVCMLsiMusi0oSgxLrAr2 jS8DA/spC1YQ8cPA7N5JdB5rgKMjKbjiNpsR2Uk+UizOemDnyqhQK7tR9K0X8I49 AiQLRcsZltQk2Nza1ow941kvIgBzWYsKSMlrxBYl4frhOiPE1nbxRNYHIAquNlj2 z56mmHf9OcRZ7Cu4rE7asvMLY03EpX3jp2QyFQcU1WMb6/U5IxCVbiv0slJVkqw= =TiuO -----END PGP SIGNATURE----- --WEeo83sTe4aDfZ7do2k183HpjXSuvX1bC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?64cf10b3-d10b-77d1-f11f-b2a7c5542213>