Date: Wed, 10 Apr 2002 14:21:36 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: Hajimu UMEMOTO <ume@mahoroba.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in.h src/sys/netinet6 in6.h Message-ID: <20020410142136.B70911@espresso.q9media.com> In-Reply-To: <yge662zfpay.wl@mille.mahoroba.org>; from ume@mahoroba.org on Thu, Apr 11, 2002 at 02:15:17AM %2B0900 References: <200204101159.g3ABx2e55901@freefall.freebsd.org> <yge662zfpay.wl@mille.mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hajimu UMEMOTO <ume@mahoroba.org> writes: > Hi, > > >>>>> On Wed, 10 Apr 2002 04:59:02 -0700 (PDT) > >>>>> Mike Barcroft <mike@FreeBSD.org> said: > > mike> mike 2002/04/10 04:59:02 PDT > > mike> Modified files: > mike> sys/netinet in.h > mike> sys/netinet6 in6.h > mike> Log: > mike> Unconditionalize the definition of INET_ADDRSTRLEN and > mike> INET6_ADDRSTRLEN. Doing this helps expose bogus redefinitions in 3rd > mike> party software. > > I cannot understand why this change is required. RFC2553 says: It isn't required, it's a matter of correctness. There was no need for them to be conditional in the first place; it was a mistake on my part to make them conditional. > addresses, the buffer must be at least 16-octets. In order to allow > applications to easily declare buffers of the proper size to store > IPv4 and IPv6 addresses in string form, the following two constants > are defined in <netinet/in.h>: > > #define INET_ADDRSTRLEN 16 > #define INET6_ADDRSTRLEN 46 > > I believe this two define shouldn't appear in application side. Right, and if they did it would be considered bogus. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020410142136.B70911>