Date: Thu, 5 Jul 2018 12:24:54 +0000 From: Antoine Brodin <antoine@freebsd.org> To: Kristof Provost <kristof@sigsegv.be> Cc: Will Andrews <will@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335833 - in head: share/man/man4 sys/net sys/netpfil/pf Message-ID: <CAALwa8=qN=uwdY5jCXprWL499JVstEM6cX14hzZw5ov8eb_==A@mail.gmail.com> In-Reply-To: <081170FC-D433-4FE6-87E1-D5470480B971@sigsegv.be> References: <201807010116.w611G35w008185@repo.freebsd.org> <CAALwa8nSgZ_nMKSGXaCj8Zbt%2BWZ47UwDQedZPPedVGeGQs7Ycw@mail.gmail.com> <081170FC-D433-4FE6-87E1-D5470480B971@sigsegv.be>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 3, 2018 at 7:42 AM, Kristof Provost <kristof@sigsegv.be> wrote: > On 3 Jul 2018, at 7:38, Antoine Brodin wrote: > > On Sun, Jul 1, 2018 at 3:16 AM, Will Andrews <will@freebsd.org> wrote: > > Author: will > Date: Sun Jul 1 01:16:03 2018 > New Revision: 335833 > URL: https://svnweb.freebsd.org/changeset/base/335833 > > Log: > pf: remove unused ioctls. > > Several ioctls are unused in pf, in the sense that no base utility > references them. Additionally, a cursory review of pf-based ports > indicates they're not used elsewhere either. Some of them have been > unused since the original import. As far as I can tell, they're also > unused in OpenBSD. Finally, removing this code removes the need for > future pf work to take them into account. > > Reviewed by: kp > Differential Revision: https://reviews.freebsd.org/D16076 > > Modified: > head/share/man/man4/pf.4 > head/sys/net/pfvar.h > head/sys/netpfil/pf/pf_ioctl.c > > Hi, > > This breaks some ports like net/libdnet, please revert or fix the > ports fallout. > > It also uses DIOCCHANGERULE (like sshuttle). > > Do you know of any other failures? > It=E2=80=99d be good to know if reverting just the DIOCCHANGERULE removal= would be > enough to fix all failures, or if there are others that are used as well. The 2 failures I see are libdnet and miniupnpd missing DIOCCHANGERULE, so adding it back may be enough. Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=qN=uwdY5jCXprWL499JVstEM6cX14hzZw5ov8eb_==A>