Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Dec 2007 14:39:54 -0600
From:      Brooks Davis <brooks@freebsd.org>
To:        Hans Petter Selasky <hselasky@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 130185 for review
Message-ID:  <20071204203954.GA43394@lor.one-eyed-alien.net>
In-Reply-To: <200712042035.lB4KZqBA000505@repoman.freebsd.org>
References:  <200712042035.lB4KZqBA000505@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On Tue, Dec 04, 2007 at 08:35:52PM +0000, Hans Petter Selasky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=130185
> 
> Change 130185 by hselasky@hselasky_laptop001 on 2007/12/04 20:35:00
> 
> 	
> 	Compile fixes for Sparc64.
> 	
> 	The change to "usb_transfer.c" is actually
> 	a bug fix.

> ==== //depot/projects/usb/src/sys/dev/usb/ums.c#31 (text+ko) ====
> 
> @@ -186,7 +186,7 @@
>  
>  		if (len > sizeof(sc->sc_temp)) {
>  			DPRINTF(5, "truncating large packet to %d bytes\n",
> -			    sizeof(sc->sc_temp));
> +			    (int)sizeof(sc->sc_temp));

You should use %zu to print size_t's, not cast them to ints.

-- Brooks

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFHVbsZXY6L6fI4GtQRAvGZAKCqQ215Ex9w0cScUTetnH5qZ9/KGQCePZYw
2TCtKVPgi5/JKEMzwYPI/uo=
=q87/
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071204203954.GA43394>