Date: Sun, 01 May 2011 10:15:29 +0530 From: ashish@freebsd.org (Ashish SHUKLA) To: Pan Tsu <inyaoo@gmail.com> Cc: cvs-ports@FreeBSD.org, Ashish SHUKLA <ashish@freebsd.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/editors/emacs-devel Makefile distinfo ports/editors/emacs-devel/files patch-Makefile.in patch-configure patch-configure.in patch-doc-emacs-Makefile.in patch-doc-lispintro-Makefile.in patch-doc-lispref-Makefile.in patch-doc-misc-Makefile.in patch-src_config.in Message-ID: <8639kzhvva.fsf@chateau.d.if> In-Reply-To: <86iptv15zc.fsf@gmail.com> (Pan Tsu's message of "Sun, 1 May 2011 06:59:03 %2B0400") References: <201104281508.p3SF8PjS068074@repoman.freebsd.org> <86tydfnbem.fsf@gmail.com> <86pqo3mhbu.fsf@chateau.d.if> <86iptv15zc.fsf@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pan Tsu writes: > ashish@freebsd.org (Ashish SHUKLA) writes: >> Pan Tsu writes: >>> - Any reason to use autogen.sh instead of relying on AUTOTOOLS? >>=20 >> Because autogen.sh works fine, and is provided by the upstream to config= ure >> the sources. So, I prefer to use upstream, unless it behaves badly. > It makes sure autotools use and dependencies are tracked properly by the > ports framework. For example, autoreconf (from autogen.sh) invokes > autoheader which you did not specify in AUTOTOOLS. Although, at the moment, it's implicitly included as autoconf is also provi= ded by same package, but I guess explicitly mentioning it is better way. So, I'= ll append "autoheader:env" to USE_AUTOTOOLS, as well. >>> - Why patch-src_config.in was lost and not converted to patch-configure= .in? >>=20 >> As I see, in src/config.in (excerpt is pasted below) which get generated >> already includes "stdlib.h", so I don't see any need of the re-including= it, >> unless you think it causes some issue. > Including stdlib.h makes sure both alloca(3) and _STDLIB_H_ are defined > at that point and no prior or future explicit inclusion of stdlib.h > redefines it. The warning described ports/149049 is still present Sorry about this :(. Thanks for the explanations, and checks you carried ou= t. I'll include the changes and commit them. =2D-=20 Ashish SHUKLA | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 freebsd.org!ashish | http://people.freebsd.org/~ashish/ Avoid Success At All Costs !! --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQIcBAEBCgAGBQJNvOVtAAoJEMdGz6nnT6Sw+0IQAJ050l7OTPpBs8JZAE7BF8UU e9ZwdBEAwR9qpYV7xc2EUu+/9qVDU63q0vQQvxHEhmmnaMIzME+4/i1aSSncQHBq CTHq3LiCyJHYJNYMwYkdaQ+fxrfbqT524UxStXVlufthDQ51s6cLLRlHH792r4Ei 9Ob/efy1hIjUARmloDLXpxnu8hbplWO8jPg0FMcv2mS1MosUY6QS9dXRY1yZg22D fUNPmZ2aaxHIh8sxaaASxsE/GAUbpaywgxN0IHuNPDP7MfEphEcj0mRad4SpO3fK to0eaPWsJBFDtkj5/d3oPs1McIzhVOs3UU6f06sYVWTmk5rRv5psMfLFiMeDMtTf thevmo+hxduPAqtqCQXN3sBPZwUq357/LkcVZUyksKXcj1j0ggmdkNfi+XfGzXIT E/qQvz/ZVz1kOdGcgbYxxOvkdigDdu4/IktOKr0i/YtfNvtPfa/KhXbjcjzZVCy0 UdKMXpdShjc0aAOQR6UqxIxD8fUotLTKxy+PD6b9QLOrRgz4W7WKHBUKYlpVkNjn kvlhshqfHkVCwsXtBkUsiFt/4sWnnvShaTeYf9Y429srGPVpMbPeu9jt72JUZes4 LhMVa6U2Q8p0EG/2RNu4OsU50eCjl1lxpk52dT1uLr2d3MsRwvmoCt3VkCOLjvEL 0V4z8nr08AREKnDiltRG =VHAt -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8639kzhvva.fsf>