Date: Fri, 27 Sep 2002 08:40:05 +0930 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Juli Mallett <jmallett@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make parse.c Message-ID: <20020926231005.GS10532@wantadilla.lemis.com> In-Reply-To: <20020926085038.GB9743@sunbay.com> References: <200209260644.g8Q6iUiv000195@freefall.freebsd.org> <20020926085038.GB9743@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, 26 September 2002 at 11:50:38 +0300, Ruslan Ermilov wrote: > On Wed, Sep 25, 2002 at 11:44:30PM -0700, Juli Mallett wrote: >> jmallett 2002/09/25 23:44:30 PDT >> >> Modified files: >> usr.bin/make parse.c >> Log: >> Remove a semicolon that appears to be a lie. >> >> Spotted by: SPARC64 make WARNS=3 >> Sponsored by: Rachel Hestilow <rachel@jerkcity.com> >> >> Revision Changes Path >> 1.43 +1 -1 src/usr.bin/make/parse.c >> > As an aside. Our make(1) suffers from the parsing bug in > parse.c:ParseReadLine(). When it sees a colon (`:') it > marks the line as being a "dependency" line, and when it > later sees a semicolon (`;') it replaces it by a newline. > The net effect is that the following fragment blows up: > > ... > > In OpenBSD, this has been fixed yet in 2001 by the new parsing code > (parse.c,v 1.59 and related changes). What's stopping you from importing the fix? Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020926231005.GS10532>