Date: Sun, 28 Feb 2010 14:53:00 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: peterjeremy@acm.org Cc: src-committers@FreeBSD.org, delphij@gmail.com, svn-src-all@FreeBSD.org, attilio@FreeBSD.org, kostikbel@gmail.com, svn-src-head@FreeBSD.org, emaste@FreeBSD.org Subject: Re: svn commit: r204309 - in head/sys: amd64/amd64 amd64/isa conf i386/bios i386/cpufreq i386/i386 i386/isa i386/xen isa modules/bios/smbios modules/bios/vpd modules/cpufreq pc98/pc98 x86 x86/bios x86/... Message-ID: <20100228.145300.29649867912530.imp@bsdimp.com> In-Reply-To: <20100228195041.GA68446@server.vk2pj.dyndns.org> References: <20100226132854.GA25722@sandvine.com> <3bbf2fe11002260557y484cf13bq76f7507c07ed3ebc@mail.gmail.com> <20100228195041.GA68446@server.vk2pj.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20100228195041.GA68446@server.vk2pj.dyndns.org>
Peter Jeremy <peterjeremy@acm.org> writes:
: On 2010-Feb-26 14:57:36 +0100, Attilio Rao <attilio@freebsd.org> wrote:
: >For the future, however, probabilly we would need to do something like
: >pc98 already does wrt i386 (i386/include/ pc98/include/ amd64/include/
: >just have files wrappers to the generic one under x86/include/ when
: >necessary).
:
: Not that something like this is also critical for getting i386/amd64
: cross compilation to work - one of the blocking issues is that the
: correct machine/ includes are not available in cross-compilatio mode.
Huh?
I cross build all the time, and the machine/ includes are always
right, with or without this patch. Maybe you could explain what you
mean here...
The issue is that old code has
#include <i386/isa.h>
or whatever in it, and we need to have an i386/isa.h that's just
#include <x86/isa.h>
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100228.145300.29649867912530.imp>