Date: Sun, 6 Aug 2006 20:12:16 -0500 From: Jose Alonso Cardenas Marquez <acm@FreeBSD.org> To: Boris Samorodov <bsam@ipt.ru> Cc: Alexander Leidinger <Alexander@Leidinger.net>, freebsd-emulation@FreeBSD.org, garga@FreeBSD.org Subject: Re: cvs commit: ports/ftp Makefile ports/ftp/linux-curl Makefile distinfo.i386 Message-ID: <20060806201216.2e569321.acm@FreeBSD.org> In-Reply-To: <82654251@bsam.ru> References: <200608041438.k74Ec3Wr096494@repoman.freebsd.org> <20060804195623.564c8a6e@Magellan.Leidinger.net> <20060804203725.efb1e8df.acm@FreeBSD.org> <36280092@bs2.sp34.ru> <95145875@bsam.ru> <20060806174543.62b15d3d.acm@FreeBSD.org> <82654251@bsam.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Mon, 07 Aug 2006 04:03:16 +0400 Boris Samorodov <bsam@ipt.ru> wrote: > On Sun, 6 Aug 2006 17:45:43 -0500 Jose Alonso Cardenas Marquez wrote: > > On Sun, 06 Aug 2006 15:15:08 +0400 > > Boris Samorodov <bsam@ipt.ru> wrote: > > Why did you use @dirrmtry at security/linux-krb5-libs/pkg-plist? ;-) > Actually, it seems to me that when in doubt you prefer to use @dirrmty > macro. I'd say that it should be quite the opposite. This macro should > be used only when you are sure that those directories are shared > between ports and there is no (so to say) "master port" which deals > with those directories. My opinion is to use @dirrmtry with care... Fixed. Maybe i don't need to work on security/linux-krb5-libs anymore, because it could be on linux_base-fc4 soon ;) > Good work! And here are some comments: > - you didn't show a diff for the distinfo; > - portrevision is not bumpted; ;-) > - at pkg-install script only empty directories are created, so there > is no need to create a usr/kerberos one; > - assume that you didn't check linux_base-fc4.diff file on TB, because > I can't manage to find a line with "@dirrm usr/kerberos" at the > plist file. I fixed all these points, you can see the TB log files. http://hellfire.no-ip.org/tb/logs/4-STABLE/linux_base-fc-4_7.log http://hellfire.no-ip.org/tb/logs/5-STABLE/linux_base-fc-4_7.log http://hellfire.no-ip.org/tb/logs/6-STABLE/linux_base-fc-4_7.log http://tb3.droso.net/logs/6-acm/linux_base-fc-4_7.log and the new diff file http://hellfire.no-ip.org/ports/linux_base-fc4.diff > Other than that seems OK. May be Alexander has something to add. > Thanks! If every things are ok, i'll send one PR with this patch. Thanks for your support :) Greetings - ---- Jose Alonso Cardenas Marquez | http://www.FreeBSD.org acm@FreeBSD.org | http://www.BSD.org.pe GnuPG Key: http://www.FreeBSD.org/~acm/pgp/pubkey.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE1pNwGV/UqJshvBkRAlUxAJwLVtGcNPaUhoG6lrP2iVCd50riTwCbBKHk ubj+5rulyAKPnEgnCMTkacM= =VAHC -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060806201216.2e569321.acm>