Date: Thu, 4 Mar 2010 05:14:23 -0700 From: Scott Long <scottl@samsco.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r194266 - head/usr.bin/chpass Message-ID: <20920CE7-2963-45F2-8D64-E36FBAAFE369@samsco.org> In-Reply-To: <20100304120250.GN8200@hoeg.nl> References: <200906152105.n5FL50Ju001949@svn.freebsd.org> <CADA450C-C67C-47DA-BF64-40FFE011B1E9@samsco.org> <20100304053221.GL8200@hoeg.nl> <20100304044516.R1188@pooker.samsco.org> <20100304120250.GN8200@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 4, 2010, at 5:02 AM, Ed Schouten wrote:
> * Scott Long <scottl@samsco.org> wrote:
>> What do you mean by "unconditionally"? Most of the utilities that
>> install themselves with 'chflags schg' do so by unconditionally
>> ignoring errors. Chpass seems to be the only exception at the
>> moment.
>
> No, I mean, don't set schg unconditionally. NO_FSCHG should still work
> afterwards. All applications currently honour this. If you create a
> FreeBSD jail and run `make installworld' a second time while inside the
> jail, this currently works, because there is not a single file which has
> schg set, which means `make installworld' can overwrite everything.
>
Does this look good?
===================================================================
--- Makefile (revision 204639)
+++ Makefile (working copy)
@@ -43,7 +43,7 @@
.if !defined(NO_FSCHG)
afterinstall:
- chflags schg ${DESTDIR}${BINDIR}/chpass
+ -chflags schg ${DESTDIR}${BINDIR}/chpass
.endif
.include <bsd.prog.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20920CE7-2963-45F2-8D64-E36FBAAFE369>