Date: Tue, 4 Nov 2014 10:54:56 +0000 From: David Chisnall <theraven@FreeBSD.org> To: Stefan Farfeleder <stefanf@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, "Alexander V. Chernikov" <melifaro@FreeBSD.org> Subject: Re: svn commit: r274086 - head/sbin/route Message-ID: <C17BDEA3-7BF7-4EB7-A8E2-A8D202425576@FreeBSD.org> In-Reply-To: <20141104102828.GB1215@mole.fafoe.narf.at> References: <201411041021.sA4ALZ4m001202@svn.freebsd.org> <20141104102828.GB1215@mole.fafoe.narf.at>
index | next in thread | previous in thread | raw e-mail
On 4 Nov 2014, at 10:28, Stefan Farfeleder <stefanf@FreeBSD.org> wrote: > Shouldn't Coverity understand that err doesn't return? err() is marked as __dead2, which expands to __attribute__((__noreturn__)). If Coverity doesn't know that __attribute__((__noreturn__)) functions don't return, then that's a Coverity bug and they should fix it (if we're not expanding __dead3 to __attribute__((__noreturn__)) for Coverity, then that's a sys/cdefs.h bug and should be fixed there). Putting a break after a noreturn function makes the code less readable and will cause errors in non-buggy static analysers (dead code warning - why do you have a break on an unreachable line?). Davidhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C17BDEA3-7BF7-4EB7-A8E2-A8D202425576>