Date: Tue, 25 Apr 2000 10:59:26 -0500 From: "C. Stephen Gunn" <csg@waterspout.com> To: Archie Cobbs <archie@whistle.com> Cc: Julian Elischer <julian@elischer.org>, pavel@alum.mit.edu, nsayer@sftw.com, luigi@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: Proposal for ethernet, bridging, netgraph Message-ID: <20000425105926.A518@waterspout.com> In-Reply-To: <200004250214.TAA30215@bubba.whistle.com>; from archie@whistle.com on Mon, Apr 24, 2000 at 07:14:44PM -0700 References: <3902A56B.167EB0E7@elischer.org> <200004250214.TAA30215@bubba.whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 24, 2000 at 07:14:44PM -0700, Archie Cobbs wrote: > OK, here's a patch ready for review & test.. this patch does one > thing, which is move the calls to BPF and BRIDGE'ing out of each > Ethernet driver and into ether_input(). Why not also modify ether_input() to remove the Ethernet header when appropriate? Instead of the monkey business to add the Ethernet Header back on. There are a couple of places in ether_input() that do this already, and you're proposing another for passing the packet to bpf. I proposed this a few weeks ago, but never cleaned up my patch for submission. <sigh> It would certainly prevent some of the kludges to deal with the Ethernet Header for things that want a peek at it, like VLANs. - Steve To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000425105926.A518>