Date: Sat, 14 Nov 2020 15:50:36 -0500 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Mateusz Guzik <mjg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367692 - head/sys/sys Message-ID: <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> In-Reply-To: <202011141920.0AEJKbpO050396@repo.freebsd.org> References: <202011141920.0AEJKbpO050396@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6hglt7f3pnphonso Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 14, 2020 at 07:20:37PM +0000, Mateusz Guzik wrote: > Author: mjg > Date: Sat Nov 14 19:20:37 2020 > New Revision: 367692 > URL: https://svnweb.freebsd.org/changeset/base/367692 >=20 > Log: > cred: reorder cr_audit to be closer to the lock > =20 > This makes cr_uid avoid sharing. >=20 > Modified: > head/sys/sys/ucred.h >=20 > Modified: head/sys/sys/ucred.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/ucred.h Sat Nov 14 19:19:27 2020 (r367691) > +++ head/sys/sys/ucred.h Sat Nov 14 19:20:37 2020 (r367692) > @@ -63,6 +63,7 @@ struct ucred { > struct mtx cr_mtx; > u_int cr_ref; /* (c) reference count */ > u_int cr_users; /* (c) proc + thread using this cred */ > + struct auditinfo_addr cr_audit; /* Audit properties. */ > #define cr_startcopy cr_uid > uid_t cr_uid; /* effective user id */ > uid_t cr_ruid; /* real user id */ > @@ -78,7 +79,6 @@ struct ucred { > void *cr_pspare2[2]; /* general use 2 */ > #define cr_endcopy cr_label > struct label *cr_label; /* MAC label */ > - struct auditinfo_addr cr_audit; /* Audit properties. */ > gid_t *cr_groups; /* groups */ > int cr_agroups; /* Available groups */ > gid_t cr_smallgroups[XU_NGROUPS]; /* storage for small groups */ Hey Mateusz, Since this changes KBI, does __FreeBSD_version need bumping? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --6hglt7f3pnphonso Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl+wQxkACgkQ/y5nonf4 4fqmvw/+LqkXst4/4+Gu+hoTF4T05ao+JGmx/RG6xHteFNhIYR2Y63VSscIv+kHT 8tSus5N6WrSgdaN2nwxpv/dYxR6Z8CEM+5OjFEwoEqaWugu6rWxLAyhDrPkNkKvT bka4vAvZPiHxfQqwWuE7aMoWd+4O9LFl8WSLc7zLIe9rQsjr2E5woHldG8u/mheF tw1kle1JK8hIzy5Qfi62FUvEtIhpI4Vo60wXeUV8iXnUHUEC6L4umeY447blLkKp kqyvP7BUjMB5bgZVvNpzgKQ+Lx3zDpl1SVcJznN069OQm1xzGs+Ob5gam75eG5at BqzJRB0cD0snH5dQBqhiij3cd4L8/B5p/OK+klqEgOWfIryDVH0C1uiH0eXzZPZR 9Zawk5hIV2LevbHzuWiM/Fg98dpyOEjvRPc5bs7L1w5mqC5l7X3lzZEXOeaUa/HW ZJoje5ocYEST1wlDkrJ8JFw/rTrNxDA7Rm/5kPTZv8sBzhXNC+1ZELUf129BUktc jNcmxwdqlt/CAU2vuz49A+R0yOESEY50gy6K3GDai/gF+jKNJ0DLUlvdLsWUT4zm Zmn98N3cNVPSPkHKXJbJVxr3bamYRK23w2S/NFuxMWug1R4oYNs4oimSFxL69bXF /Y2XdCX92S7N8EiepAGG0j3QdMCJZUhKi/fXU6CdMtkzJhyMv2I= =zV3q -----END PGP SIGNATURE----- --6hglt7f3pnphonso--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201114205036.tnxvwarsddmu4shz>