Date: Wed, 3 Apr 2002 14:56:19 +0700 From: Alexey Dokuchaev <danfe@regency.nsu.ru> To: Julian Elischer <julian@elischer.org> Cc: Kenneth Culver <culverk@alpha.yumyumyum.org>, Mike Barcroft <mike@freebsd.org>, Matthew Dillon <dillon@apollo.backplane.com>, "M. Warner Losh" <imp@village.org>, jake@locore.ca, dillon@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alph Message-ID: <20020403145619.A31477@regency.nsu.ru> In-Reply-To: <Pine.BSF.4.21.0204021118220.21569-100000@InterJet.elischer.org>; from julian@elischer.org on Tue, Apr 02, 2002 at 11:22:53AM -0800 References: <20020402100957.C45652-100000@alpha.yumyumyum.org> <Pine.BSF.4.21.0204021118220.21569-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 02, 2002 at 11:22:53AM -0800, Julian Elischer wrote:
>
>
> On Tue, 2 Apr 2002, Kenneth Culver wrote:
>
> > > > if (a) {
> > > > x;
> > > > y;
> > > > } else
> > > > /*
> > > > * HITHERE!
> > > > */
> > > > b;
> > >
> > > This looks better with proper 8 character tabs. I think in KNF extra
> > > braces are normally used in situations like this, but this is an edge
> > > case.
> >
> > 8 character tabs? why use tabs at all? That requires an
> > engineer/programmer to set that in an editor, and a lot of people don't
> > like having tabs that are that large... I just use spaces because then my
> > code will look the same as when I wrote it no matter what editor is used,
> > and no matter what the tabs are set to.
>
> Then your code would be different from all other code in FreeBSD.
> Code checeked in should be 8 character tabs.. this is one of the most
> BASIC requirements, even if some developers feel themselves too important
> to abide by it.. It is one of the first things that gives the BSD
> code base a unified appearance.
I totally agree: from what I've seen, faaaar most of BSD code looks so
unified (read: neat and appealing), contrary to Linux' one, for instance
;-)
Methinks it's very inappropriate to destroy that style(9) tradition of
years...
./danfe
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020403145619.A31477>