Date: Thu, 24 Jul 2025 15:44:11 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Kristof Provost <kp@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4bb3b3657764 - main - pf: unify DPFPRINTF definitions Message-ID: <aIK3Oy3K0xNuv__4@cell.glebi.us> In-Reply-To: <202507231423.56NENthc031396@gitrepo.freebsd.org> References: <202507231423.56NENthc031396@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 23, 2025 at 02:23:55PM +0000, Kristof Provost wrote: K> commit 4bb3b365776458bd8f710e40f97e2c68994e3306 K> Author: Kristof Provost <kp@FreeBSD.org> K> AuthorDate: 2025-07-18 14:55:35 +0000 K> K> pf: unify DPFPRINTF definitions K> K> We define DPFPRINTF() in a few different versions in most pf source files. K> Move to one definition in pfvar.h and use that one everywhere. K> K> While here change it to add an endline, as OpenBSD does, so we consistently end K> all logs with an endline. K> Also add a static probe point to ease future debugging. This way we can detect K> log evens even when logging is disabled, and extract more information (e.g. K> stack traces, frequency, ...). Thanks a lot! Every time I was debugging something in pf, I was missing those SDTs. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aIK3Oy3K0xNuv__4>