Date: Sat, 5 Feb 2011 23:00:48 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@FreeBSD.org, Adrian Chadd <adrian@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r218238 - head/sys/dev/ath Message-ID: <20110205120047.GE20095@server.vk2pj.dyndns.org> In-Reply-To: <4D4C27E5.2020708@bsdimp.com> References: <201102032026.p13KQQX2057419@svn.freebsd.org> <20110203230721.GA47981@muon.cran.org.uk> <4D4C27E5.2020708@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Lb0e7rgc7IsuDeGj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2011-Feb-04 09:23:01 -0700, Warner Losh <imp@bsdimp.com> wrote:
>On 02/03/2011 16:07, Bruce Cran wrote:
>> On Thu, Feb 03, 2011 at 08:26:26PM +0000, Adrian Chadd wrote:
>>> if (ni !=3D NULL) {
>>> +#if NOTYET
>>> /* tag AMPDU aggregates for reorder processing */
>> This seems to have broken the build because NOTYET isn't defined.
>
>ANSI C states that all undefined preprocessor variables shall expand to=20
>0. If we have a warning on that complains, we should turn it off.
Well, bde@ considers it a style bug so from that point of view, the
warning is useful. Also, given that the normal way of stating that
is "#ifdef NOTYET", keeping the warning may help catch code where
the preprocessor variable was supposed to have been defined but has
been misspelt - consider "#if _FreeBSD_version > 800100".
--=20
Peter Jeremy
--Lb0e7rgc7IsuDeGj
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (FreeBSD)
iEYEARECAAYFAk1NO+8ACgkQ/opHv/APuIcR/QCeJmAdOeV8kG2u+bTgTkiBESGm
jPQAoJ9RGexE1HSVesXs4OYdkzZKfTSe
=aTK9
-----END PGP SIGNATURE-----
--Lb0e7rgc7IsuDeGj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110205120047.GE20095>