Date: Sat, 14 Sep 2019 12:36:24 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Peter Jeremy <peter@rulingia.com>, Baptiste Daroussin <bapt@freebsd.org>, Charlie Li <ml+freebsd@vishwin.info>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline Message-ID: <2D5BFAF9-7A03-4A2C-B406-19AA8BC8BF5D@FreeBSD.org> In-Reply-To: <CANCZdfocTme=zHcA%2BtbdLqmZFpJEr-bRYZ22FCDBqk06=XdSEw@mail.gmail.com> References: <201909130650.x8D6o2fb037276@repo.freebsd.org> <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> <20190914041041.GA97181@server.rulingia.com> <CANCZdfocTme=zHcA%2BtbdLqmZFpJEr-bRYZ22FCDBqk06=XdSEw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_4B83A316-21D1-46A8-ACB1-444D07C617CC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 14 Sep 2019, at 06:25, Warner Losh <imp@bsdimp.com> wrote: >=20 > On Fri, Sep 13, 2019, 10:11 PM Peter Jeremy <peter@rulingia.com> = wrote: > On 2019-Sep-13 16:33:15 -0400, Charlie Li <ml+freebsd@vishwin.info> = wrote: > >Baptiste Daroussin wrote: > >> Author: bapt > >> Date: Fri Sep 13 06:50:02 2019 > >> New Revision: 352275 > >> URL: https://svnweb.freebsd.org/changeset/base/352275 > >> > >> Log: > >> Update libedit to a snapshot from 2019-09-10 > >> Reviewed by: Yuichiro Naito <naito.yuichiro_gmail.com> > >> MFC after: 3 weeks > >> Differential Revision: https://reviews.freebsd.org/D21584 > >> > >I posted in phab but repeating here, this breaks the build on (at = least) > >aarch64: >=20 > It breaks the build on arm and arm64 only. >=20 > wint_t is int on all platforms: > sys/sys/_types.h: > typedef int __ct_rune_t; /* arg type for ctype funcs */ > typedef __ct_rune_t __wint_t; /* wint_t (see above) */ >=20 > but wchar_t varies between unsigned and signed: > $ grep '__wchar_t' sys/*/include/_types.h > sys/arm/include/_types.h:typedef unsigned int ___wchar_t; > sys/arm64/include/_types.h:typedef unsigned int ___wchar_t; > sys/mips/include/_types.h:typedef int ___wchar_t; > sys/powerpc/include/_types.h:typedef int ___wchar_t; > sys/riscv/include/_types.h:typedef int ___wchar_t; > sys/sparc64/include/_types.h:typedef int ___wchar_t; > sys/x86/include/_types.h:typedef int ___wchar_t; >=20 > Looking back into history, it looks like the "unsigned" is part > of the ARM EABI. >=20 > We should confirm that. It is definitely part of the OABI stuff, but = EABI was supposed to fix differences like this... As far as I know, arm has always been the odd one out, but even then, you should assume anything about the signedness of char. :) In any case, I have put up a fix for review here, which sidesteps that issue: https://reviews.freebsd.org/D21657 -Dimitry --Apple-Mail=_4B83A316-21D1-46A8-ACB1-444D07C617CC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXXzCqAAKCRCwXqMKLiCW ozx9AJ444XH15u1oO1QhjtwQJ3iBDNTdVgCg8Lp0HLCGxH7ZUaGKrFaMfRFJusU= =ix0J -----END PGP SIGNATURE----- --Apple-Mail=_4B83A316-21D1-46A8-ACB1-444D07C617CC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2D5BFAF9-7A03-4A2C-B406-19AA8BC8BF5D>