Date: Wed, 22 May 2024 12:36:31 +0200 From: Dmitry Salychev <dsl@FreeBSD.org> To: Lexi Winter <lexi@le-fay.org> Cc: Mariusz Zaborski <oshogbo@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 408957613bc0 - main - Regen Message-ID: <86r0dugmik.fsf@peasant.tower.home> In-Reply-To: <Zk2lBymRapenk_V8@ilythia.eden.le-fay.org> References: <202405212004.44LK4cBG042804@gitrepo.freebsd.org> <Zk2lBymRapenk_V8@ilythia.eden.le-fay.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Lexi Winter <lexi@le-fay.org> writes: > [[PGP Signed Part:Undecided]] > Mariusz Zaborski: >> The branch main has been updated by oshogbo: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c4444812c3ae276ace03697ebd >> >> commit 408957613bc065c4444812c3ae276ace03697ebd >> Author: Mariusz Zaborski <oshogbo@FreeBSD.org> >> AuthorDate: 2024-05-21 20:02:50 +0000 >> Commit: Mariusz Zaborski <oshogbo@FreeBSD.org> >> CommitDate: 2024-05-21 20:03:20 +0000 >> >> Regen >> --- >> sys/compat/freebsd32/freebsd32_sysent.c | 2 +- >> sys/kern/init_sysent.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > i'm sorry if this is considered accepted practice in FreeBSD (i'm not a > committer) but could i please request more useful commit messages than > "Regen" for things like this? > > when looking through 'git log', especially 'git log --format=oneline', > it's really not clear what this commit actually does, meaning if i'm > looking through the log for commits related to a problem i'm having, i > have to examine commits like this by hand to see if they're related. > > it would save me (and other people, i suppose) a lot of time if the > commit message could at least mention what it's touching, e.g. "Regen > sys/compat/freebsd32/freebsd32_sysent.c". > > [[End of PGP Signed Part]] Looks like it slipped in by mistake. I expected it to be reverted and re-worded. Regards, Dmitry -- https://wiki.freebsd.org/DmitrySalychev
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86r0dugmik.fsf>