Date: Wed, 22 May 2002 13:05:36 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern kern Message-ID: <XFMail.20020522130536.jhb@FreeBSD.org> In-Reply-To: <20020523013305.B10069-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22-May-2002 Bruce Evans wrote: > On Wed, 22 May 2002, John Baldwin wrote: > >> jhb 2002/05/22 06:19:22 PDT >> >> Modified files: >> sys/i386/include cpufunc.h >> sys/kern kern_mutex.c >> Log: >> Rename cpu_pause() to pause(). Originally I was going to make this an >> MI API with empty cpu_pause() functions on other arch's, but this >> functionality is definitely unique to IA-32, so I decided to leave it >> as i386-only and wrap it in #ifdef's. I should have dropped the cpu_ >> prefix when I made that decision. >> >> Requested by: bde >> >> Revision Changes Path >> 1.122 +1 -1 src/sys/i386/include/cpufunc.h >> 1.96 +5 -5 src/sys/kern/kern_mutex.c > > Thanks. Er, I'm not sure that this is an improvement, since the ugly >#ifdefs are now meant to stay :-). Well, I'm not a big fan of the #ifdef's either, but I think having bogus empty cpu_pause() implementations for all our other arch's is worse.. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020522130536.jhb>