Date: Wed, 13 Sep 2006 16:58:10 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk Message-ID: <20060913235810.GA87164@dragon.NUXI.org> In-Reply-To: <20060913233211.GA83839@toxic.magnesium.net> References: <200609132327.k8DNRMqS076204@repoman.freebsd.org> <20060913233211.GA83839@toxic.magnesium.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 13, 2006 at 01:32:11PM -1000, Juli Mallett wrote: > [ cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk ] > > When building WITHOUT_ASSERT_DEBUG, we need to disable -Werror as its easy > > to see "warning: unused variable `foo'". > > I think it might be a better idea to -Wno-unused, since the only sorts of > warnings one wants to ignore building NDEBUG are the variables which are > otherwise unused. Hum.. I assumed that WITHOUT_ASSERT_DEBUG was a rare case and used as part of producing a production release where one knows /usr/src builds as-usual. -Wno-unused would scratch this itch, but we need to find a way to codify it so that we're not putting GCC options into share/mk. I guess make a NO_WUNUSED knob. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060913235810.GA87164>